Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183813004: Add +refs/tags/*:refs/tags/* to git cache config (Closed)

Created:
6 years, 9 months ago by hinoka
Modified:
6 years, 9 months ago
Reviewers:
Ryan Tseng, agable
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Add +refs/tags/*:refs/tags/* to git cache config For some reason "--tags" wasn't working on some versions of git (pre-1.9) BUG=339171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=253929

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/replace-all/add/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M git_cache.py View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hinoka
6 years, 9 months ago (2014-02-27 21:03:24 UTC) #1
agable
https://codereview.chromium.org/183813004/diff/1/git_cache.py File git_cache.py (right): https://codereview.chromium.org/183813004/diff/1/git_cache.py#newcode200 git_cache.py:200: RunGit(['config', '--replace-all', 'remote.origin.fetch', Definitely not --replace-all. You want --add ...
6 years, 9 months ago (2014-02-27 21:15:03 UTC) #2
Ryan Tseng
https://codereview.chromium.org/183813004/diff/1/git_cache.py File git_cache.py (right): https://codereview.chromium.org/183813004/diff/1/git_cache.py#newcode200 git_cache.py:200: RunGit(['config', '--replace-all', 'remote.origin.fetch', On 2014/02/27 21:15:04, agable wrote: > ...
6 years, 9 months ago (2014-02-27 21:29:05 UTC) #3
agable
lgtm
6 years, 9 months ago (2014-02-27 21:30:47 UTC) #4
Ryan Tseng
The CQ bit was checked by hinoka@google.com
6 years, 9 months ago (2014-02-27 21:31:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@chromium.org/183813004/20001
6 years, 9 months ago (2014-02-27 21:31:24 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-02-27 21:33:53 UTC) #7
Message was sent while issue was closed. 
Change committed as 253929

Powered by Google App Engine
This is Rietveld 408576698