Add +refs/tags/*:refs/tags/* to git cache config

git_cache.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A git command for managing a local cache of git repositories."""
 
 import errno
 import logging
 import optparse
@@ skipping 179 matching lines @@
     d = ['--depth', '%d' % options.depth]
 
   def _config(directory):
     RunGit(['config', 'core.deltaBaseCacheLimit', '2g'],
            cwd=directory)
     RunGit(['config', 'remote.origin.url', NormalizeUrl(url)],
            cwd=directory)
     RunGit(['config', '--replace-all', 'remote.origin.fetch',
             '+refs/heads/*:refs/heads/*'],
            cwd=directory)
+    RunGit(['config', '--replace-all', 'remote.origin.fetch',

[agable, 2014/02/27 21:15:04]

Definitely not --replace-all. You want --add instead.

[Ryan Tseng, 2014/02/27 21:29:05]

Done.

+            '+refs/tags/*:refs/tags/*'],
+           cwd=directory)
     for ref in options.ref or []:
       ref = ref.rstrip('/')
       refspec = '+refs/%s/*:refs/%s/*' % (ref, ref)
       RunGit(['config', '--add', 'remote.origin.fetch', refspec],
              cwd=directory)
 
   with Lockfile(repo_dir):
     # Setup from scratch if the repo is new or is in a bad state.
     if not os.path.exists(os.path.join(repo_dir, 'config')):
       gclient_utils.rmtree(repo_dir)
       tempdir = tempfile.mkdtemp(suffix=UrlToCacheDir(url),
                                  dir=options.cache_dir)
       RunGit(['init', '--bare'], cwd=tempdir)
       _config(tempdir)
-      fetch_cmd = ['fetch'] + v + d + ['--tags', 'origin']
+      fetch_cmd = ['fetch'] + v + d + ['origin']
       RunGit(fetch_cmd, filter_fn=filter_fn, cwd=tempdir, retry=True)
       os.rename(tempdir, repo_dir)
     else:
       _config(repo_dir)
       if options.depth and os.path.exists(os.path.join(repo_dir, 'shallow')):
         logging.warn('Shallow fetch requested, but repo cache already exists.')
-      fetch_cmd = ['fetch'] + v + ['--tags', 'origin']
+      fetch_cmd = ['fetch'] + v + ['origin']
       RunGit(fetch_cmd, filter_fn=filter_fn, cwd=repo_dir, retry=True)
 
 
 @subcommand.usage('[url of repo to unlock, or -a|--all]')
 def CMDunlock(parser, args):
   """Unlock one or all repos if their lock files are still around."""
   parser.add_option('--force', '-f', action='store_true',
                     help='Actually perform the action')
   parser.add_option('--all', '-a', action='store_true',
                     help='Unlock all repository caches')
@@ skipping 62 matching lines @@
     return options, args
 
 
 def main(argv):
   dispatcher = subcommand.CommandDispatcher(__name__)
   return dispatcher.execute(OptionParser(), argv)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))