Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1838083005: PNaCl: Add --force-pnacl-subzero to chrome://flags . (Closed)

Created:
4 years, 8 months ago by Jim Stichnoth
Modified:
4 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PNaCl: Add --force-pnacl-subzero to chrome://flags . Publicizing this already-existing flag makes it much easier to test Subzero, both internally and externally, and especially on an ARM-based Chromebook. BUG=598970 Committed: https://crrev.com/bfeeeb7527723a0154fc30621232b8f10ca4d199 Cr-Commit-Position: refs/heads/master@{#384297}

Patch Set 1 #

Patch Set 2 : Limit to Desktop OS #

Patch Set 3 : Add histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
Jim Stichnoth
4 years, 8 months ago (2016-03-30 16:47:00 UTC) #4
sehr
lgtm
4 years, 8 months ago (2016-03-30 17:17:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838083005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838083005/40001
4 years, 8 months ago (2016-03-31 03:45:42 UTC) #7
Jim Stichnoth
+asvitkine for histograms.xml file
4 years, 8 months ago (2016-03-31 03:54:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/162394)
4 years, 8 months ago (2016-03-31 03:56:48 UTC) #11
Alexei Svitkine (slow)
lgtm
4 years, 8 months ago (2016-03-31 14:34:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838083005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838083005/40001
4 years, 8 months ago (2016-03-31 14:38:18 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/166995)
4 years, 8 months ago (2016-03-31 15:42:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838083005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838083005/40001
4 years, 8 months ago (2016-03-31 15:45:17 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-31 16:08:33 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 16:10:14 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bfeeeb7527723a0154fc30621232b8f10ca4d199
Cr-Commit-Position: refs/heads/master@{#384297}

Powered by Google App Engine
This is Rietveld 408576698