Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1838043002: Disabled "Print" option in wrench menu for a crashed page. (Closed)

Created:
4 years, 8 months ago by Tom (Use chromium acct)
Modified:
4 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, Lei Zhang, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabled "Print" option in wrench menu for a crashed page. BUG=596407 Committed: https://crrev.com/9094aa5cd380fcdb8c12f984c2276a0e87a8c24d Cr-Commit-Position: refs/heads/master@{#384619}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Disabled "Print" option in wrench menu for a crashed page. #

Total comments: 1

Patch Set 3 : Disabled "Print" option in wrench menu for a crashed page. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M chrome/browser/ui/browser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_unittest.cc View 1 2 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Tom (Use chromium acct)
4 years, 8 months ago (2016-03-29 02:18:02 UTC) #2
Peter Kasting
This should ideally have a test that will fail if the INVALIDATE_TYPE_TAB change is reverted, ...
4 years, 8 months ago (2016-03-29 02:55:13 UTC) #3
Dirk Pranke
I defer to pkasting here ...
4 years, 8 months ago (2016-03-29 18:57:37 UTC) #4
Tom (Use chromium acct)
I've added a unit test and made sure it fails if INVALIDATE_TYPE_TAB is removed. https://codereview.chromium.org/1838043002/diff/1/chrome/browser/ui/browser_commands.cc ...
4 years, 8 months ago (2016-03-31 17:13:44 UTC) #6
Peter Kasting
LGTM https://codereview.chromium.org/1838043002/diff/20001/chrome/browser/ui/browser_unittest.cc File chrome/browser/ui/browser_unittest.cc (right): https://codereview.chromium.org/1838043002/diff/20001/chrome/browser/ui/browser_unittest.cc#newcode81 chrome/browser/ui/browser_unittest.cc:81: EXPECT_FALSE(contents->IsCrashed()); Nit: Move the IsCrashed() check to the ...
4 years, 8 months ago (2016-03-31 21:59:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838043002/40001
4 years, 8 months ago (2016-04-01 01:02:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/203609)
4 years, 8 months ago (2016-04-01 07:04:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838043002/40001
4 years, 8 months ago (2016-04-01 17:26:56 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-01 17:33:09 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 17:35:01 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9094aa5cd380fcdb8c12f984c2276a0e87a8c24d
Cr-Commit-Position: refs/heads/master@{#384619}

Powered by Google App Engine
This is Rietveld 408576698