Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5549)

Unified Diff: chrome/browser/ui/browser_unittest.cc

Issue 1838043002: Disabled "Print" option in wrench menu for a crashed page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disabled "Print" option in wrench menu for a crashed page. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_unittest.cc
diff --git a/chrome/browser/ui/browser_unittest.cc b/chrome/browser/ui/browser_unittest.cc
index 5d152002fa913b3d49e00e5243f5fdc45485bec4..e8d6bd56b7099458528590b8d154ceec18034162 100644
--- a/chrome/browser/ui/browser_unittest.cc
+++ b/chrome/browser/ui/browser_unittest.cc
@@ -5,6 +5,8 @@
#include "chrome/browser/ui/browser.h"
#include "base/macros.h"
+#include "chrome/app/chrome_command_ids.h"
+#include "chrome/browser/ui/browser_command_controller.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/browser_with_test_window_test.h"
@@ -63,6 +65,28 @@ TEST_F(BrowserUnitTest, ReloadCrashedTab) {
EXPECT_TRUE(contents2->IsCrashed());
}
+// Ensure the print command gets disabled when a tab crashes.
+TEST_F(BrowserUnitTest, DisablePrintOnCrashedTab) {
+ TabStripModel* tab_strip_model = browser()->tab_strip_model();
+
+ WebContents* contents = CreateTestWebContents();
+ tab_strip_model->AppendWebContents(contents, true);
+ WebContentsTester::For(contents)->NavigateAndCommit(GURL("about:blank"));
+
+ CommandUpdater* command_updater =
+ browser()->command_controller()->command_updater();
+
+ EXPECT_FALSE(contents->IsCrashed());
+ EXPECT_TRUE(command_updater->IsCommandEnabled(IDC_PRINT));
+ EXPECT_TRUE(chrome::CanPrint(browser()));
+
+ contents->SetIsCrashed(base::TERMINATION_STATUS_PROCESS_CRASHED, -1);
+
+ EXPECT_TRUE(contents->IsCrashed());
+ EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_PRINT));
+ EXPECT_FALSE(chrome::CanPrint(browser()));
+}
+
class BrowserBookmarkBarTest : public BrowserWithTestWindowTest {
public:
BrowserBookmarkBarTest() {}
« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698