clean up partition check in url_data_manager_backend.cc

content/public/browser/content_browser_client.cc

Index: content/public/browser/content_browser_client.cc
diff --git a/content/public/browser/content_browser_client.cc b/content/public/browser/content_browser_client.cc
index c669268c36a1f752c6b469dddd4e5f23e0850dc9..51f38a1b10a665b2fcac0d1ff4afa30adaafe7c9 100644
--- a/content/public/browser/content_browser_client.cc
+++ b/content/public/browser/content_browser_client.cc
@@ -5,6 +5,7 @@
 #include "content/public/browser/content_browser_client.h"
 
 #include "base/files/file_path.h"
+#include "content/public/common/url_constants.h"
 #include "ui/gfx/image/image_skia.h"
 #include "url/gurl.h"
 
@@ -36,6 +37,11 @@ bool ContentBrowserClient::ShouldUseProcessPerSite(
   return false;
 }
 
+void ContentBrowserClient::GetWebUIHostsToIgnoreParititionCheck(
+    std::vector<std::string>* hosts) {
+  hosts->push_back(kChromeUIResourcesHost);

[jam, 2014/03/05 22:29:46]

this file should just be empty methods. move this to the calling code which
should just add kChromeUIResourcesHost to the vector before calling this method

after that, no need to change this cc file

[guohui, 2014/03/05 23:04:24]

then is it better to move this line to the subclass ContentBrowserClient instead
of the calling code? Otherwise every caller has to know the logic and dup the
code.

[jam, 2014/03/06 01:54:47]

if you do my comment in url_data_manager_backend.cc, then you don't ned to have
this line anywhere other than url_data_manager_backend

+}
+
 net::URLRequestContextGetter* ContentBrowserClient::CreateRequestContext(
     BrowserContext* browser_context,
     ProtocolHandlerMap* protocol_handlers) {