clean up partition check in url_data_manager_backend.cc

content/public/browser/content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/content_browser_client.h"
 
 #include "base/files/file_path.h"
+#include "content/public/common/url_constants.h"
 #include "ui/gfx/image/image_skia.h"
 #include "url/gurl.h"
 
 namespace content {
 
 BrowserMainParts* ContentBrowserClient::CreateBrowserMainParts(
     const MainFunctionParams& parameters) {
   return NULL;
 }
 
@@ skipping 11 matching lines @@
 GURL ContentBrowserClient::GetEffectiveURL(BrowserContext* browser_context,
                                            const GURL& url) {
   return url;
 }
 
 bool ContentBrowserClient::ShouldUseProcessPerSite(
     BrowserContext* browser_context, const GURL& effective_url) {
   return false;
 }
 
+void ContentBrowserClient::GetWebUIHostsToIgnoreParititionCheck(
+    std::vector<std::string>* hosts) {
+  hosts->push_back(kChromeUIResourcesHost);

[jam, 2014/03/05 22:29:46]

this file should just be empty methods. move this to the calling code which
should just add kChromeUIResourcesHost to the vector before calling this method

after that, no need to change this cc file

[guohui, 2014/03/05 23:04:24]

then is it better to move this line to the subclass ContentBrowserClient instead
of the calling code? Otherwise every caller has to know the logic and dup the
code.

[jam, 2014/03/06 01:54:47]

if you do my comment in url_data_manager_backend.cc, then you don't ned to have
this line anywhere other than url_data_manager_backend

+}
+
 net::URLRequestContextGetter* ContentBrowserClient::CreateRequestContext(
     BrowserContext* browser_context,
     ProtocolHandlerMap* protocol_handlers) {
   return NULL;
 }
 
 net::URLRequestContextGetter*
 ContentBrowserClient::CreateRequestContextForStoragePartition(
     BrowserContext* browser_context,
     const base::FilePath& partition_path,
@@ skipping 253 matching lines @@
     content::BrowserContext* browser_context,
     const GURL& url) {
   return false;
 }
 
 bool ContentBrowserClient::IsPluginAllowedToUseDevChannelAPIs() {
   return false;
 }
 
 }  // namespace content