Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183793002: Make start/stop loading notifications per-frame (Closed)

Created:
6 years, 9 months ago by Nate Chapin
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, aboxhall, abarth-chromium, dglazkov+blink, dmazzoni, gavinp+loader_chromium.org, Nate Chapin
Visibility:
Public.

Description

Make start/stop loading notifications per-frame Also, make ProgressTracker a frame-level concept rather than a page-level concept and merge it with FrameLoader's FrameProgressTracker helper. Send per-frame progress change notifications accordingly. This depends on https://codereview.chromium.org/180113003/ landing in chromium. BUG=347643 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170192

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -170 lines) Patch
M Source/core/accessibility/AXRenderObject.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 2 chunks +5 lines, -10 lines 0 comments Download
M Source/core/loader/FrameLoader.h View 1 2 3 4 chunks +3 lines, -4 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 2 3 3 chunks +3 lines, -51 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/loader/ProgressTracker.h View 3 chunks +6 lines, -8 lines 0 comments Download
M Source/core/loader/ProgressTracker.cpp View 8 chunks +25 lines, -50 lines 0 comments Download
M Source/core/page/Page.h View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/core/page/Page.cpp View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 2 3 2 chunks +9 lines, -16 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M public/web/WebFrameClient.h View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M public/web/WebViewClient.h View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
Nate Chapin
6 years, 9 months ago (2014-03-12 16:57:49 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-12 19:34:34 UTC) #2
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-12 19:47:50 UTC) #3
Nate Chapin
The CQ bit was unchecked by japhet@chromium.org
6 years, 9 months ago (2014-03-12 19:48:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/183793002/20001
6 years, 9 months ago (2014-03-12 19:48:00 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 20:17:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_blink_compile
6 years, 9 months ago (2014-03-12 20:17:01 UTC) #7
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-27 16:00:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/183793002/60001
6 years, 9 months ago (2014-03-27 16:00:48 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 16:26:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 16:26:58 UTC) #11
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-27 16:27:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/183793002/60001
6 years, 9 months ago (2014-03-27 16:27:36 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 16:52:05 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 16:52:06 UTC) #15
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-27 16:53:15 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/183793002/60001
6 years, 9 months ago (2014-03-27 16:53:24 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 17:04:00 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 17:04:00 UTC) #19
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-27 17:08:57 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/183793002/60001
6 years, 9 months ago (2014-03-27 17:08:59 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 17:33:44 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 17:33:44 UTC) #23
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-27 17:38:27 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/183793002/60001
6 years, 9 months ago (2014-03-27 17:38:32 UTC) #25
commit-bot: I haz the power
Change committed as 170192
6 years, 9 months ago (2014-03-27 18:25:28 UTC) #26
enne (OOO)
6 years, 9 months ago (2014-03-27 23:00:28 UTC) #27
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/215533004/ by enne@chromium.org.

The reason for reverting is: Possibly causing content_browsertests EndToEnd to
fail.

See:
http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%2...

Output:
[20917:20917:0327/122353:3268961829:INFO:CONSOLE(0)] "Uncaught TypeError: Cannot
convert undefined or null to object", source:
http://127.0.0.1:34379/files/web_ui_mojo.html (0)
[20917:20917:0327/122353:3269022437:INFO:CONSOLE(28)] "Uncaught TypeError:
undefined is not a function", source:
http://127.0.0.1:34379/files/web_ui_mojo.js (28)
BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x000000a593be base::debug::StackTrace::StackTrace()
#1 0x000002bfc17b content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f9c3e4ab4a0 <unknown>
#3 0x7f9c3e55da43 __poll
#4 0x7f9c42aabff6 <unknown>
#5 0x7f9c42aac124 g_main_context_iteration
#6 0x000000aaaf5f base::MessagePumpGlib::RunWithDispatcher()
#7 0x000000a8e802 base::RunLoop::Run()
#8 0x00000058256e content::(anonymous
namespace)::WebUIMojoTest_EndToEnd_Test::RunTestOnMainThread().

Powered by Google App Engine
This is Rietveld 408576698