Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1837923003: Remove font logging in unit tests. (Closed)

Created:
4 years, 8 months ago by dtapuska
Modified:
4 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove font logging in unit tests. Remove some useless logging in the unit tests when under debug. If the tests fail; they will print the expected/actual difference. BUG=596760 Committed: https://crrev.com/6da403bdb4e5636c246055f14e2d28f4049ff9a9 Cr-Commit-Position: refs/heads/master@{#383706}

Patch Set 1 #

Patch Set 2 : Remove all LogFonts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M third_party/WebKit/Source/platform/Logging.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Logging.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/SmallCapsIteratorTest.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dtapuska
4 years, 8 months ago (2016-03-29 02:46:07 UTC) #3
tkent
lgtm
4 years, 8 months ago (2016-03-29 03:09:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837923003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837923003/20001
4 years, 8 months ago (2016-03-29 12:51:59 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 12:56:34 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 12:58:48 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6da403bdb4e5636c246055f14e2d28f4049ff9a9
Cr-Commit-Position: refs/heads/master@{#383706}

Powered by Google App Engine
This is Rietveld 408576698