third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp - Issue 1837923003: Remove font logging in unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp

Issue 1837923003: Remove font logging in unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove all LogFonts Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/Logging.cpp ('k') | third_party/WebKit/Source/platform/fonts/SmallCapsIteratorTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp b/third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp

index 47ccac7c433a50c3ffca4e22390e6f3b9d35ba22..5b46ae0fc96ecd42e5082334089a8b5615588269 100644

--- a/third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp

+++ b/third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp

@@ -28,13 +28,6 @@ struct ExpectedRun {

class OrientationIteratorTest : public testing::Test {

protected:

-#if !LOG_DISABLED

- static void SetUpTestCase()

- {

- LogFonts = { WTFLogChannelOn };

- }

-#endif

void CheckRuns(const Vector<TestRun>& runs)

{

String text(emptyString16Bit());

@@ -59,7 +52,6 @@ protected:

ASSERT_EQ(expect[runCount].renderOrientation, renderOrientation);

++runCount;

}

- WTF_LOG(Fonts, "Expected %zu runs, got %lu ", expect.size(), runCount);

ASSERT_EQ(expect.size(), runCount);

}

};