ChromeOS: Refactor TimeZoneResolver, add TimeZoneResolverManager.

ChromeOS: Refactor TimeZoneResolver, add TimeZoneResolverManager.

This CL adds TimeZoneResolverManager as asingle point of TimeZoneResolver
control.

BUG=596690
TEST=manual

Committed: https://crrev.com/75b7a5c0d16c45d5c96664343f1d77daa63d7212
Cr-Commit-Position: refs/heads/master@{#383680}

[Alexander Alekseev, 2016-03-29 01:50:46]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 01:50:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1837893003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1837893003/1

[Alexander Alekseev, 2016-03-29 01:53:55]

alemate@chromium.org changed reviewers:
+ stevenjb@chromium.org, thestig@chromium.org

[Alexander Alekseev, 2016-03-29 01:53:55]

THis is the first part of https://codereview.chromium.org/1836433003/

Please review:

thestig@:
  c/b/browser_process_platform_part_chromeos.*

stevenjb@:
  all the rest.

[stevenjb, 2016-03-29 02:15:55]

Thanks, much easier to review in smaller pieces.
LGTM w/ nits

https://codereview.chromium.org/1837893003/diff/1/chrome/browser/chromeos/sys...
File chrome/browser/chromeos/system/timezone_resolver_manager.cc (right):

https://codereview.chromium.org/1837893003/diff/1/chrome/browser/chromeos/sys...
chrome/browser/chromeos/system/timezone_resolver_manager.cc:111: result =
GetServiceConfigurationFromPolicy();
nit: ServiceConfiguration result = Get...();

https://codereview.chromium.org/1837893003/diff/1/chrome/browser/chromeos/sys...
File chrome/browser/chromeos/system/timezone_resolver_manager.h (right):

https://codereview.chromium.org/1837893003/diff/1/chrome/browser/chromeos/sys...
chrome/browser/chromeos/system/timezone_resolver_manager.h:38: bool
IsTimeZoneResolverShouldBeRunnig();
nit: Just 'TimeZoneResolverShouldBeRunning'

https://codereview.chromium.org/1837893003/diff/1/chromeos/timezone/timezone_...
File chromeos/timezone/timezone_resolver.cc (right):

https://codereview.chromium.org/1837893003/diff/1/chromeos/timezone/timezone_...
chromeos/timezone/timezone_resolver.cc:439: DCHECK(delegate_);
nit: move DCHECK to the constructor where it is set.

[commit-bot: I haz the power, 2016-03-29 02:37:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 02:37:53]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2016-03-29 03:46:36]

https://codereview.chromium.org/1837893003/diff/1/chrome/browser/chromeos/sys...
File chrome/browser/chromeos/system/timezone_resolver_manager.cc (right):

https://codereview.chromium.org/1837893003/diff/1/chrome/browser/chromeos/sys...
chrome/browser/chromeos/system/timezone_resolver_manager.cc:111: result =
GetServiceConfigurationFromPolicy();
On 2016/03/29 02:15:55, stevenjb wrote:
> nit: ServiceConfiguration result = Get...();

Done.

https://codereview.chromium.org/1837893003/diff/1/chrome/browser/chromeos/sys...
File chrome/browser/chromeos/system/timezone_resolver_manager.h (right):

https://codereview.chromium.org/1837893003/diff/1/chrome/browser/chromeos/sys...
chrome/browser/chromeos/system/timezone_resolver_manager.h:38: bool
IsTimeZoneResolverShouldBeRunnig();
On 2016/03/29 02:15:55, stevenjb wrote:
> nit: Just 'TimeZoneResolverShouldBeRunning'

Done.

https://codereview.chromium.org/1837893003/diff/1/chromeos/timezone/timezone_...
File chromeos/timezone/timezone_resolver.cc (right):

https://codereview.chromium.org/1837893003/diff/1/chromeos/timezone/timezone_...
chromeos/timezone/timezone_resolver.cc:439: DCHECK(delegate_);
On 2016/03/29 02:15:55, stevenjb wrote:
> nit: move DCHECK to the constructor where it is set.

Done.

[Lei Zhang, 2016-03-29 05:11:11]

lgtm

[Alexander Alekseev, 2016-03-29 05:20:40]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2016-03-29 05:20:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1837893003/#ps40001
(title: "Update after review.")

[commit-bot: I haz the power, 2016-03-29 05:20:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1837893003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1837893003/40001

[commit-bot: I haz the power, 2016-03-29 06:39:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-29 06:41:02]

Description was changed from

==========
ChromeOS: Refactor TimeZoneResolver, add TimeZoneResolverManager.

This CL adds TimeZoneResolverManager as asingle point of TimeZoneResolver
control.

BUG=596690
TEST=manual
==========

to

==========
ChromeOS: Refactor TimeZoneResolver, add TimeZoneResolverManager.

This CL adds TimeZoneResolverManager as asingle point of TimeZoneResolver
control.

BUG=596690
TEST=manual

Committed: https://crrev.com/75b7a5c0d16c45d5c96664343f1d77daa63d7212
Cr-Commit-Position: refs/heads/master@{#383680}
==========

[commit-bot: I haz the power, 2016-03-29 06:41:03]

Patchset 3 (id:??) landed as
https://crrev.com/75b7a5c0d16c45d5c96664343f1d77daa63d7212
Cr-Commit-Position: refs/heads/master@{#383680}