Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.h

Issue 1837873003: Do not update Resource::overheadSize() for ResourceRequest's URL modifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/Resource.h
diff --git a/third_party/WebKit/Source/core/fetch/Resource.h b/third_party/WebKit/Source/core/fetch/Resource.h
index d6fb85193f76aa55e2f2309b4bac9f0eb5681142..2ac16e512c8006d769bc261668630c60509d8025 100644
--- a/third_party/WebKit/Source/core/fetch/Resource.h
+++ b/third_party/WebKit/Source/core/fetch/Resource.h
@@ -149,7 +149,7 @@ public:
size_t size() const { return encodedSize() + decodedSize() + overheadSize(); }
size_t encodedSize() const { return m_encodedSize; }
size_t decodedSize() const { return m_decodedSize; }
- size_t overheadSize() const;
+ size_t overheadSize() const { return m_overheadSize; }
bool isLoaded() const { return m_status > Pending; }
@@ -330,6 +330,8 @@ private:
void revalidationSucceeded(const ResourceResponse&);
void revalidationFailed();
+ size_t calculateOverheadSize() const;
+
bool unlock();
void setCachedMetadata(unsigned dataTypeID, const char*, size_t, CachedMetadataHandler::CacheType);
@@ -353,6 +355,13 @@ private:
size_t m_encodedSize;
size_t m_decodedSize;
+
+ // Resource::calculateOverheadSize() is affected by changes in
+ // |m_resourceRequest.url()|, but |m_overheadSize| is not updated after
+ // initial |m_resourceRequest| is given, to reduce MemoryCache manipulation
+ // and thus potential bugs. crbug.com/594644
+ const size_t m_overheadSize;
+
unsigned m_preloadCount;
String m_cacheIdentifier;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fetch/Resource.cpp » ('j') | third_party/WebKit/Source/core/fetch/Resource.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698