Do not update Resource::overheadSize() for ResourceRequest's URL modifications

third_party/WebKit/Source/core/fetch/Resource.cpp

Index: third_party/WebKit/Source/core/fetch/Resource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/Resource.cpp b/third_party/WebKit/Source/core/fetch/Resource.cpp
index a311e3f2bc0c214dec20f2802340b62ba17c1db3..97ec43a817f8a4556697347fb6229b1ed4337b39 100644
--- a/third_party/WebKit/Source/core/fetch/Resource.cpp
+++ b/third_party/WebKit/Source/core/fetch/Resource.cpp
@@ -156,6 +156,7 @@ Resource::Resource(const ResourceRequest& request, Type type, const ResourceLoad
     , m_identifier(0)
     , m_encodedSize(0)
     , m_decodedSize(0)
+    , m_overheadSize(calculateOverheadSize())
     , m_preloadCount(0)
     , m_cacheIdentifier(MemoryCache::defaultCacheIdentifier())
     , m_preloadResult(PreloadNotReferenced)
@@ -898,7 +899,7 @@ bool Resource::lock()
     return true;
 }
 
-size_t Resource::overheadSize() const
+size_t Resource::calculateOverheadSize() const
 {
     static const int kAverageClientsHashMapSize = 384;
     return sizeof(Resource) + m_response.memoryUsage() + kAverageClientsHashMapSize + m_resourceRequest.url().getString().length() * 2;

[Nate Chapin, 2016/03/29 18:17:34]

This is the only callsite of m_response.memoryUsage(), and the comment on
memoryUsage() hints at obsolete WebKit-era overriding of its value. Can we just
inline it here?

[hiroshige, 2016/03/29 19:19:00]

I'll do it in a separate CL to keep this crash-fixing CL small.