Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1837873003: Do not update Resource::overheadSize() for ResourceRequest's URL modifications (Closed)

Created:
4 years, 8 months ago by hiroshige
Modified:
4 years, 8 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not update Resource::overheadSize() for ResourceRequest's URL modifications Resource::size() and Resource::overheadSize() can be changed if |m_resourceRequest|'s URL is changed, and this might corrupt MemoryCache's LRU lists due to inconsistency between Resource::size() and the LRU list that the Resource belongs to. This CL makes Resource::overheadSize() to be constant after Resource's construction to avoid this due to |m_resourceRequest|'s URL modifications introduced by https://codereview.chromium.org/1757633005 and any potential modifications. BUG=594644 Committed: https://crrev.com/14f135a371fda7b70a446227e4e69c7c7e45beec Cr-Commit-Position: refs/heads/master@{#383794}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M third_party/WebKit/Source/core/fetch/Resource.h View 3 chunks +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 2 chunks +2 lines, -1 line 2 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837873003/1
4 years, 8 months ago (2016-03-29 00:09:06 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 01:18:51 UTC) #5
hiroshige
PTAL.
4 years, 8 months ago (2016-03-29 01:38:31 UTC) #7
Nate Chapin
LGTM with a nit. https://codereview.chromium.org/1837873003/diff/1/third_party/WebKit/Source/core/fetch/Resource.cpp File third_party/WebKit/Source/core/fetch/Resource.cpp (right): https://codereview.chromium.org/1837873003/diff/1/third_party/WebKit/Source/core/fetch/Resource.cpp#newcode905 third_party/WebKit/Source/core/fetch/Resource.cpp:905: return sizeof(Resource) + m_response.memoryUsage() + ...
4 years, 8 months ago (2016-03-29 18:17:35 UTC) #8
hiroshige
https://codereview.chromium.org/1837873003/diff/1/third_party/WebKit/Source/core/fetch/Resource.cpp File third_party/WebKit/Source/core/fetch/Resource.cpp (right): https://codereview.chromium.org/1837873003/diff/1/third_party/WebKit/Source/core/fetch/Resource.cpp#newcode905 third_party/WebKit/Source/core/fetch/Resource.cpp:905: return sizeof(Resource) + m_response.memoryUsage() + kAverageClientsHashMapSize + m_resourceRequest.url().getString().length() * ...
4 years, 8 months ago (2016-03-29 19:19:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837873003/1
4 years, 8 months ago (2016-03-29 19:19:22 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 19:30:41 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 19:32:17 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14f135a371fda7b70a446227e4e69c7c7e45beec
Cr-Commit-Position: refs/heads/master@{#383794}

Powered by Google App Engine
This is Rietveld 408576698