Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1837793002: MD Settings: Certificate manager dialogs strings tweaks. (Closed)

Created:
4 years, 8 months ago by dpapad
Modified:
4 years, 8 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Certificate manager dialogs strings tweaks. Also removing the always-float-label per latest mocks. BUG=595767, 595770 Committed: https://crrev.com/c0a344efc18963c4acc44070c68b96ee29b43025 Cr-Commit-Position: refs/heads/master@{#383635}

Patch Set 1 : More #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -20 lines) Patch
M chrome/app/settings_strings.grdp View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_password_encryption_dialog.html View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
dpapad
4 years, 8 months ago (2016-03-28 20:14:56 UTC) #9
dschuyler
lgtm
4 years, 8 months ago (2016-03-29 00:25:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837793002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837793002/80001
4 years, 8 months ago (2016-03-29 00:38:31 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:80001)
4 years, 8 months ago (2016-03-29 00:43:21 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 00:44:35 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0a344efc18963c4acc44070c68b96ee29b43025
Cr-Commit-Position: refs/heads/master@{#383635}

Powered by Google App Engine
This is Rietveld 408576698