Migrate extensions/* to net::IPAddress.

extensions/browser/api/cast_channel/logger.cc

Index: extensions/browser/api/cast_channel/logger.cc
diff --git a/extensions/browser/api/cast_channel/logger.cc b/extensions/browser/api/cast_channel/logger.cc
index ba187da8772721b1c3e6cb972e503066d842ade9..0958451c30d736154b370658111e7eb36528465c 100644
--- a/extensions/browser/api/cast_channel/logger.cc
+++ b/extensions/browser/api/cast_channel/logger.cc
@@ -144,8 +144,8 @@ void Logger::LogNewSocketEvent(const CastSocket& cast_socket) {
   AggregatedSocketEvent& aggregated_socket_event =
       LogSocketEvent(cast_socket.id(), event);
 
-  const net::IPAddressNumber& ip = cast_socket.ip_endpoint().address().bytes();
-  aggregated_socket_event.set_endpoint_id(ip.back());
+  const net::IPAddress& ip = cast_socket.ip_endpoint().address();
+  aggregated_socket_event.set_endpoint_id(ip.bytes().back());

[eroman, 2016/03/29 18:10:51]

As far as refactoring goes, this is a correct.

But not familiar with this code to know if the pre-existing code is right -- the
assumption is that |ip| is non-empty. Seems plausible that is correct though :)

[Wez, 2016/03/29 20:46:29]

Fair point; |cast_socket.ip_endpoint()| is the address supplied to the
CastChannel::Open() API, so by the time we reach here we can assume it's valid -
I'd prefer a DCHECK here to document that, ideally.

[martijnc, 2016/03/29 21:00:48]

Added.

   aggregated_socket_event.set_channel_auth_type(cast_socket.channel_auth() ==
                                                         CHANNEL_AUTH_TYPE_SSL
                                                     ? proto::SSL