compute_engine_scripts/telemetry/telemetry_slave_scripts/test_data/summary.json - Issue 183763025: vm_run_skia_try/write_json_summary: run skpdiff within imagediffdb, not on its own

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compute_engine_scripts/telemetry/telemetry_slave_scripts/test_data/summary.json

Issue 183763025: vm_run_skia_try/write_json_summary: run skpdiff within imagediffdb, not on its own (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master

Patch Set: ravi's comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compute_engine_scripts/telemetry/telemetry_slave_scripts/test_data/output.csv ('k') | compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_skia_try.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compute_engine_scripts/telemetry/telemetry_slave_scripts/test_data/summary.json

diff --git a/compute_engine_scripts/telemetry/telemetry_slave_scripts/test_data/summary.json b/compute_engine_scripts/telemetry/telemetry_slave_scripts/test_data/summary.json

index 0ad876f71c105ee40ffa7fb2ad76d56050d0459a..493260ecedca3f6dd4e5aae21ac96a6821b25f29 100644

--- a/compute_engine_scripts/telemetry/telemetry_slave_scripts/test_data/summary.json

+++ b/compute_engine_scripts/telemetry/telemetry_slave_scripts/test_data/summary.json

@@ -6,7 +6,7 @@

"maxDiffPerChannel": 4,

"numPixelsDiffering": 1,

"percentPixelsDiffering": 2,

- "perceptualSimilarity": 0.3,

+ "perceptualSimilarity": 5,

"skpLocation": "gs://dummy-bucket/skps/file_.skp",

"weightedDiffMeasure": 3

@@ -15,7 +15,7 @@