compute_engine_scripts/telemetry/telemetry_slave_scripts/test_data/summary.json - Issue 183763025: vm_run_skia_try/write_json_summary: run skpdiff within imagediffdb, not on its own

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: compute_engine_scripts/telemetry/telemetry_slave_scripts/test_data/summary.json

Issue 183763025: vm_run_skia_try/write_json_summary: run skpdiff within imagediffdb, not on its own (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master

Patch Set: ravi's comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « compute_engine_scripts/telemetry/telemetry_slave_scripts/test_data/output.csv ('k') | compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_skia_try.sh » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "slave1": {	2 "slave1": {

3 "failedFiles": [	3 "failedFiles": [

4 {	4 {

5 "fileName": "file_3.png",	5 "fileName": "file_3.png",

6 "maxDiffPerChannel": 4,	6 "maxDiffPerChannel": 4,

7 "numPixelsDiffering": 1,	7 "numPixelsDiffering": 1,

8 "percentPixelsDiffering": 2,	8 "percentPixelsDiffering": 2,

9 "perceptualSimilarity": 0.3,	9 "perceptualSimilarity": 5,

10 "skpLocation": "gs://dummy-bucket/skps/file_.skp",	10 "skpLocation": "gs://dummy-bucket/skps/file_.skp",

11 "weightedDiffMeasure": 3	11 "weightedDiffMeasure": 3

12 },	12 },

13 {	13 {

14 "fileName": "file_.png",	14 "fileName": "file_.png",

15 "maxDiffPerChannel": 4,	15 "maxDiffPerChannel": 4,

16 "numPixelsDiffering": 1,	16 "numPixelsDiffering": 1,

17 "percentPixelsDiffering": 2,	17 "percentPixelsDiffering": 2,

18 "perceptualSimilarity": 0.1,	18 "perceptualSimilarity": 5,

19 "skpLocation": "gs://dummy-bucket/skps/file_.skp",	19 "skpLocation": "gs://dummy-bucket/skps/file_.skp",

20 "weightedDiffMeasure": 3	20 "weightedDiffMeasure": 3

21 }	21 }

22 ],	22 ],

23 "failedFilesCount": 2,	23 "failedFilesCount": 2,

24 "filesLocationDiffs": "gs://dummy-bucket/output-dir/slave1/diffs",	24 "filesLocationDiffs": "gs://dummy-bucket/output-dir/slave1/diffs",

25 "filesLocationNopatch": "gs://dummy-bucket/output-dir/slave1/nopatch-ima ges",	25 "filesLocationNopatch": "gs://dummy-bucket/output-dir/slave1/nopatch-ima ges",

26 "filesLocationWhiteDiffs": "gs://dummy-bucket/output-dir/slave1/whitedif fs",	26 "filesLocationWhiteDiffs": "gs://dummy-bucket/output-dir/slave1/whitedif fs",

27 "filesLocationWithpatch": "gs://dummy-bucket/output-dir/slave1/withpatch -images",	27 "filesLocationWithpatch": "gs://dummy-bucket/output-dir/slave1/withpatch -images",

28 "skpsLocation": "gs://dummy-bucket/skps"	28 "skpsLocation": "gs://dummy-bucket/skps"

29 }	29 }

30 }	30 }

OLD	NEW