[oilpan] Move CSSFontFace and CSSSegmentedFontFace to the managed heap

Source/core/css/CSSFontFaceSource.h

Index: Source/core/css/CSSFontFaceSource.h
diff --git a/Source/core/css/CSSFontFaceSource.h b/Source/core/css/CSSFontFaceSource.h
index 9e9f9ea9c3a4c1f19b66c4208e85920c7b5cc3fb..0576936c8b871521758cbd3ebf751a67ec8b4e7f 100644
--- a/Source/core/css/CSSFontFaceSource.h
+++ b/Source/core/css/CSSFontFaceSource.h
@@ -55,7 +55,7 @@ public:
 
     const AtomicString& string() const { return m_string; }
 
-    void setFontFace(CSSFontFace* face) { m_face = face; }
+    void setFontFace(Handle<CSSFontFace> face) { m_face = face; }
 
     virtual void fontLoaded(CachedFont*);
 
@@ -78,7 +78,7 @@ private:
 
     AtomicString m_string; // URI for remote, built-in font name for local.
     CachedResourceHandle<CachedFont> m_font; // For remote fonts, a pointer to our cached resource.
-    CSSFontFace* m_face; // Our owning font face.
+    Persistent<CSSFontFace> m_face; // Our owning font face.

[Mads Ager (chromium), 2013/07/02 14:59:23]

This looks like a definite leak. The CSSFontFace has the source in an OwnPtr.
But now, the CSSFontFace cannot die because the CSSFontFace holds a persistent
to it.

Either leave this as a raw pointer with a FIXME(oilpan) comment or add a
FIXME(oilpan) comment stating that this is a leak and work on moving the
CSSFontFaceSource to the oilpan heap.

[haraken, 2013/07/03 04:39:20]

Good point. Done.

     HashMap<unsigned, RefPtr<SimpleFontData> > m_fontDataTable; // The hash key is composed of size synthetic styles.
 
 #if ENABLE(SVG_FONTS)