[oilpan] Move CSSFontFace and CSSSegmentedFontFace to the managed heap

Source/core/css/CSSFontFaceSource.h

 /*
  * Copyright (C) 2007, 2008, 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 37 matching lines @@
 class CSSFontFaceSource : public CachedFontClient {
 public:
     CSSFontFaceSource(const String&, CachedFont* = 0);
     virtual ~CSSFontFaceSource();
 
     bool isLoaded() const;
     bool isValid() const;
 
     const AtomicString& string() const { return m_string; }
 
-    void setFontFace(CSSFontFace* face) { m_face = face; }
+    void setFontFace(Handle<CSSFontFace> face) { m_face = face; }
 
     virtual void fontLoaded(CachedFont*);
 
     PassRefPtr<SimpleFontData> getFontData(const FontDescription&, bool syntheticBold, bool syntheticItalic, CSSFontSelector*);
 
     void pruneTable();
 
 #if ENABLE(SVG_FONTS)
     SVGFontFaceElement* svgFontFaceElement() const;
     void setSVGFontFaceElement(PassRefPtr<SVGFontFaceElement>);
     bool isSVGFontFaceSource() const;
     void setHasExternalSVGFont(bool value) { m_hasExternalSVGFont = value; }
 #endif
 
     bool isDecodeError() const;
     bool ensureFontData();
 
 private:
     void startLoadingTimerFired(Timer<CSSFontFaceSource>*);
 
     AtomicString m_string; // URI for remote, built-in font name for local.
     CachedResourceHandle<CachedFont> m_font; // For remote fonts, a pointer to our cached resource.
-    CSSFontFace* m_face; // Our owning font face.
+    Persistent<CSSFontFace> m_face; // Our owning font face.

[Mads Ager (chromium), 2013/07/02 14:59:23]

This looks like a definite leak. The CSSFontFace has the source in an OwnPtr.
But now, the CSSFontFace cannot die because the CSSFontFace holds a persistent
to it.

Either leave this as a raw pointer with a FIXME(oilpan) comment or add a
FIXME(oilpan) comment stating that this is a leak and work on moving the
CSSFontFaceSource to the oilpan heap.

[haraken, 2013/07/03 04:39:20]

Good point. Done.

     HashMap<unsigned, RefPtr<SimpleFontData> > m_fontDataTable; // The hash key is composed of size synthetic styles.
 
 #if ENABLE(SVG_FONTS)
     RefPtr<SVGFontFaceElement> m_svgFontFaceElement;
     RefPtr<SVGFontElement> m_externalSVGFontElement;
     bool m_hasExternalSVGFont;
 #endif
 };
 
 }
 
 #endif