Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1837453003: SkPDF: remove margin foolishness (Closed)

Created:
4 years, 9 months ago by hal.canary
Modified:
4 years, 9 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -91 lines) Patch
M src/pdf/SkPDFDevice.h View 3 chunks +0 lines, -25 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 9 chunks +19 lines, -66 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
hal.canary
TAL
4 years, 9 months ago (2016-03-25 21:21:11 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837453003/1
4 years, 9 months ago (2016-03-25 21:22:17 UTC) #6
bungeman-skia
lgtm
4 years, 9 months ago (2016-03-25 21:23:36 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-25 21:35:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837453003/1
4 years, 9 months ago (2016-03-25 21:43:27 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 21:44:36 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/73557f6c3f98c13aa3c5db285ce95b9ecc5730b5

Powered by Google App Engine
This is Rietveld 408576698