Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: src/pdf/SkPDFDevice.h

Issue 1837453003: SkPDF: remove margin foolishness (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/pdf/SkPDFDevice.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/pdf/SkPDFDevice.h
diff --git a/src/pdf/SkPDFDevice.h b/src/pdf/SkPDFDevice.h
index 095bbe96379a1d21adf9b34859c85795174dcdb4..628546aeec77d47b142de56c89f80c75060f636a 100644
--- a/src/pdf/SkPDFDevice.h
+++ b/src/pdf/SkPDFDevice.h
@@ -131,22 +131,6 @@ public:
void onDetachFromCanvas() override;
SkImageInfo imageInfo() const override;
- enum DrawingArea {
- kContent_DrawingArea, // Drawing area for the page content.
- kMargin_DrawingArea, // Drawing area for the margin content.
- };
-
- /** Sets the drawing area for the device. Subsequent draw calls are directed
- * to the specific drawing area (margin or content). The default drawing
- * area is the content drawing area.
- *
- * Currently if margin content is drawn and then a complex (for PDF) xfer
- * mode is used, like SrcIn, Clear, etc, the margin content will get
- * clipped. A simple way to avoid the bug is to always draw the margin
- * content last.
- */
- void setDrawingArea(DrawingArea drawingArea);
-
// PDF specific methods.
/** Create the resource dictionary for this device. */
@@ -250,15 +234,9 @@ private:
SkAutoTDelete<ContentEntry> fContentEntries;
ContentEntry* fLastContentEntry;
- SkAutoTDelete<ContentEntry> fMarginContentEntries;
- ContentEntry* fLastMarginContentEntry;
- DrawingArea fDrawingArea;
const SkClipStack* fClipStack;
- // Accessor and setter functions based on the current DrawingArea.
- SkAutoTDelete<ContentEntry>* getContentEntries();
-
// Glyph ids used for each font on this device.
SkAutoTDelete<SkPDFGlyphSetMap> fFontGlyphUsage;
@@ -274,9 +252,6 @@ private:
SkPDFDocument* doc,
bool flip);
- ContentEntry* getLastContentEntry();
- void setLastContentEntry(ContentEntry* contentEntry);
-
SkBaseDevice* onCreateDevice(const CreateInfo&, const SkPaint*) override;
void init();
« no previous file with comments | « no previous file | src/pdf/SkPDFDevice.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698