content/browser/download/download_item_impl.cc - Issue 183743019: delete file if resume mode is invalid. DCHECK fails in DownloadItemImpl::OnDownloadRenamedToFinalNa…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_item_impl.cc

Issue 183743019: delete file if resume mode is invalid. DCHECK fails in DownloadItemImpl::OnDownloadRenamedToFinalNa… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/download/download_item_impl.cc

diff --git a/content/browser/download/download_item_impl.cc b/content/browser/download/download_item_impl.cc

index 865e7a01f34804c11fd4ca96243ba40ad9089d5a..ca7e68e6118deaf4d2cd435a2b7bb10fe0f47a59 100644

--- a/content/browser/download/download_item_impl.cc

+++ b/content/browser/download/download_item_impl.cc

@@ -1448,6 +1448,8 @@ void DownloadItemImpl::Interrupt(DownloadInterruptReason reason) {

// enabled for the same reason.

ReleaseDownloadFile(resume_mode == RESUME_MODE_IMMEDIATE_RESTART ||

resume_mode == RESUME_MODE_USER_RESTART ||

+ (resume_mode == RESUME_MODE_INVALID &&

asanka 2014/03/04 21:17:49 You can just check for resume_mode == RESUME_MODE_

+ last_reason_ != DOWNLOAD_INTERRUPT_REASON_NONE) ||

!IsDownloadResumptionEnabled());

// Cancel the originating URL request.

« no previous file with comments | « no previous file | no next file » | no next file with comments »