delete file if resume mode is invalid. DCHECK fails in DownloadItemImpl::OnDownloadRenamedToFinalNa…

content/browser/download/download_item_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // File method ordering: Methods in this file are in the same order as
 // in download_item_impl.h, with the following exception: The public
 // interface Start is placed in chronological order with the other
 // (private) routines that together define a DownloadItem's state
 // transitions as the download progresses.  See "Download progression
 // cascade" later in this file.
@@ skipping 1430 matching lines @@
   last_reason_ = reason;
 
   ResumeMode resume_mode = GetResumeMode();
 
   if (state_ == IN_PROGRESS_INTERNAL) {
     // Cancel (delete file) if we're going to restart; no point in leaving
     // data around we aren't going to use.  Also cancel if resumption isn't
     // enabled for the same reason.
     ReleaseDownloadFile(resume_mode == RESUME_MODE_IMMEDIATE_RESTART ||
                         resume_mode == RESUME_MODE_USER_RESTART ||
+                        (resume_mode == RESUME_MODE_INVALID &&

[asanka, 2014/03/04 21:17:49]

You can just check for resume_mode == RESUME_MODE_INVALID. The last_reason_ had
better be something other than DOWNLOAD_INTERRUPT_REASON_NONE if Interrupt() was
called :). Also update the comment above.

+                         last_reason_ != DOWNLOAD_INTERRUPT_REASON_NONE) ||
                         !IsDownloadResumptionEnabled());
 
     // Cancel the originating URL request.
     request_handle_->CancelRequest();
   } else {
     DCHECK(!download_file_.get());
   }
 
   // Reset all data saved, as even if we did save all the data we're going
   // to go through another round of downloading when we resume.
@@ skipping 321 matching lines @@
     case RESUME_MODE_USER_CONTINUE:
       return "USER_CONTINUE";
     case RESUME_MODE_USER_RESTART:
       return "USER_RESTART";
   }
   NOTREACHED() << "Unknown resume mode " << mode;
   return "unknown";
 }
 
 }  // namespace content