Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183743014: Remove the TestContextFactory, always use NullDraw GL for unit tests. (Closed)

Created:
6 years, 9 months ago by danakj
Modified:
6 years, 9 months ago
Reviewers:
no sievers
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org, piman
Visibility:
Public.

Description

Remove the TestContextFactory, always use NullDraw GL for unit tests. All unit tests suites are now opted into using real NullDraw GL contexts instead of fake "test contexts". So remove the code to create test contexts. Removes the --disable-test-compositor flag as this does nothing now that no tests use test contexts. R=sievers@chromium.org BUG=270918 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255765

Patch Set 1 : testsnulldraw: #

Total comments: 1

Patch Set 2 : testsnulldraw: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -145 lines) Patch
M ui/compositor/compositor.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/compositor/compositor_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor_switches.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/compositor/test/context_factories_for_test.cc View 2 chunks +2 lines, -29 lines 0 comments Download
D ui/compositor/test/test_context_factory.h View 1 chunk +0 lines, -45 lines 0 comments Download
D ui/compositor/test/test_context_factory.cc View 1 chunk +0 lines, -66 lines 0 comments Download

Messages

Total messages: 32 (0 generated)
danakj
https://codereview.chromium.org/183743014/diff/20001/ui/gl/gl_surface.cc File ui/gl/gl_surface.cc (right): https://codereview.chromium.org/183743014/diff/20001/ui/gl/gl_surface.cc#newcode98 ui/gl/gl_surface.cc:98: void GLSurface::InitializeOneOffForTests(bool disable_drawing) { I'll remove this disable_drawing flag ...
6 years, 9 months ago (2014-03-03 18:08:03 UTC) #1
danakj
I moved the gl_surface.cc change over to https://codereview.chromium.org/176843008/ since it makes more sense there, and ...
6 years, 9 months ago (2014-03-03 18:14:20 UTC) #2
no sievers
lgtm
6 years, 9 months ago (2014-03-03 18:41:07 UTC) #3
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-03 18:41:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/183743014/30001
6 years, 9 months ago (2014-03-03 18:42:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/183743014/30001
6 years, 9 months ago (2014-03-03 20:00:48 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 20:08:11 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 9 months ago (2014-03-03 20:08:11 UTC) #8
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-03 20:08:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/183743014/30001
6 years, 9 months ago (2014-03-03 20:13:45 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 20:16:39 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 9 months ago (2014-03-03 20:16:40 UTC) #12
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-03 20:17:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/183743014/30001
6 years, 9 months ago (2014-03-03 20:18:45 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 20:20:06 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 9 months ago (2014-03-03 20:20:06 UTC) #16
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-03 21:17:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/183743014/30001
6 years, 9 months ago (2014-03-03 21:19:55 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 22:49:28 UTC) #19
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=273444
6 years, 9 months ago (2014-03-03 22:49:29 UTC) #20
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-06 18:17:44 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/183743014/30001
6 years, 9 months ago (2014-03-06 18:19:53 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 18:38:59 UTC) #23
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests, telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=233272
6 years, 9 months ago (2014-03-06 18:39:00 UTC) #24
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-06 18:39:41 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/183743014/30001
6 years, 9 months ago (2014-03-06 18:44:38 UTC) #26
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 9 months ago (2014-03-06 20:05:44 UTC) #27
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-07 18:17:17 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/183743014/30001
6 years, 9 months ago (2014-03-07 18:19:33 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/183743014/30001
6 years, 9 months ago (2014-03-07 20:21:59 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/183743014/30001
6 years, 9 months ago (2014-03-08 10:49:33 UTC) #31
commit-bot: I haz the power
6 years, 9 months ago (2014-03-08 12:08:04 UTC) #32
Message was sent while issue was closed. 
Change committed as 255765

Powered by Google App Engine
This is Rietveld 408576698