Remove the TestContextFactory, always use NullDraw GL for unit tests.

ui/gl/gl_surface.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_surface.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 77 matching lines @@
              << " GL implementation.";
     if (gpu_service_logging)
       InitializeDebugGLBindings();
     if (disable_gl_drawing)
       InitializeNullDrawGLBindings();
   }
   return initialized;
 }
 
 // static
 void GLSurface::InitializeOneOffForTests(bool disable_drawing) {

[danakj, 2014/03/03 18:08:04]

I'll remove this disable_drawing flag in a next CL.

   DCHECK_EQ(kGLImplementationNone, GetGLImplementation());
 
 #if defined(USE_X11)
   XInitThreads();
 #endif
 
   bool use_osmesa = true;
 
   // We usually use OSMesa as this works on all bots. The command line can
   // override this behaviour to use hardware GL.
@@ skipping 11 matching lines @@
 
   GLImplementation impl = allowed_impls[0];
   if (use_osmesa)
     impl = kGLImplementationOSMesaGL;
 
   DCHECK(!CommandLine::ForCurrentProcess()->HasSwitch(switches::kUseGL))
       << "kUseGL has not effect in tests";
 
   bool fallback_to_osmesa = false;
   bool gpu_service_logging = false;
-  bool disable_gl_drawing = disable_drawing;
-  // TODO(danakj): Unit tests do not produce pixel output by default.
-  // bool disable_gl_drawing = true;
+  // Unit tests do not produce pixel output by default.
+  bool disable_gl_drawing = true;
 
   CHECK(InitializeOneOffImplementation(
       impl, fallback_to_osmesa, gpu_service_logging, disable_gl_drawing));
 }
 
 // static
 void GLSurface::InitializeOneOffWithMockBindingsForTests() {
   DCHECK(!CommandLine::ForCurrentProcess()->HasSwitch(switches::kUseGL))
       << "kUseGL has not effect in tests";
 
@@ skipping 197 matching lines @@
   return surface_->GetFormat();
 }
 
 VSyncProvider* GLSurfaceAdapter::GetVSyncProvider() {
   return surface_->GetVSyncProvider();
 }
 
 GLSurfaceAdapter::~GLSurfaceAdapter() {}
 
 }  // namespace gfx