Issue 183743006: Revert 253994 "[Mac] Remove NSApplication from the renderer."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183743006: Revert 253994 "[Mac] Remove NSApplication from the renderer." (Closed)

Created:
6 years, 9 months ago by Peter Kasting

Modified:
6 years, 9 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 253994 "[Mac] Remove NSApplication from the renderer." Speculative revert to see if this is causing Mac10.6 layout test bots to crash. > [Mac] Remove NSApplication from the renderer. > > This removes the +sharedApplication warmup from the renderer, along with the > trackpad IME hack. The hack is no longer necessary because NSApplication will no > longer connect to TSM. > > BUG=306348, 311899, 336642, 31225, 152566 > > Review URL: https://codereview.chromium.org/177243021 TBR=rsesek@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254034

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+107 lines, -9 lines)			Patch
M	trunk/src/content/common/sandbox_mac.mm	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	trunk/src/content/content.gyp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	trunk/src/content/renderer/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/content/renderer/renderer_main.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	trunk/src/content/renderer/renderer_main_platform_delegate_mac.mm	View	4 chunks	+93 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Peter Kasting

6 years, 9 months ago (2014-02-28 03:49:09 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r254034 (tree was closed).