Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 177243021: [Mac] Remove NSApplication from the renderer. (Closed)

Created:
6 years, 10 months ago by Robert Sesek
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[Mac] Remove NSApplication from the renderer. This removes the +sharedApplication warmup from the renderer, along with the trackpad IME hack. The hack is no longer necessary because NSApplication will no longer connect to TSM. BUG=306348, 311899, 336642, 31225, 152566 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253994 Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=254034 R=avi@chromium.org, mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254175

Patch Set 1 #

Total comments: 2

Patch Set 2 : Trim includes #

Patch Set 3 : Defer FakeActiveWindow creation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -109 lines) Patch
M content/common/sandbox_mac.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M content/content.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_main.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_mac.mm View 1 4 chunks +3 lines, -93 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestThemeEngineMac.mm View 1 2 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Robert Sesek
6 years, 10 months ago (2014-02-26 18:15:26 UTC) #1
Mark Mentovai
¡LGTM! https://codereview.chromium.org/177243021/diff/1/content/renderer/renderer_main_platform_delegate_mac.mm File content/renderer/renderer_main_platform_delegate_mac.mm (right): https://codereview.chromium.org/177243021/diff/1/content/renderer/renderer_main_platform_delegate_mac.mm#newcode14 content/renderer/renderer_main_platform_delegate_mac.mm:14: #import "base/mac/mac_util.h" Still needed? foundation_util too?
6 years, 10 months ago (2014-02-26 18:48:09 UTC) #2
Robert Sesek
https://codereview.chromium.org/177243021/diff/1/content/renderer/renderer_main_platform_delegate_mac.mm File content/renderer/renderer_main_platform_delegate_mac.mm (right): https://codereview.chromium.org/177243021/diff/1/content/renderer/renderer_main_platform_delegate_mac.mm#newcode14 content/renderer/renderer_main_platform_delegate_mac.mm:14: #import "base/mac/mac_util.h" On 2014/02/26 18:48:09, Mark Mentovai wrote: > ...
6 years, 10 months ago (2014-02-26 18:50:56 UTC) #3
Avi (use Gerrit)
lgtm Sweet!
6 years, 10 months ago (2014-02-26 18:55:23 UTC) #4
Robert Sesek
The CQ bit was checked by rsesek@chromium.org
6 years, 9 months ago (2014-02-27 18:16:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/177243021/20001
6 years, 9 months ago (2014-02-27 18:17:11 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 18:34:24 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=52480
6 years, 9 months ago (2014-02-27 18:34:24 UTC) #8
Robert Sesek
The CQ bit was checked by rsesek@chromium.org
6 years, 9 months ago (2014-02-27 18:35:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/177243021/20001
6 years, 9 months ago (2014-02-27 18:36:28 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 19:01:52 UTC) #11
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=52511
6 years, 9 months ago (2014-02-27 19:01:52 UTC) #12
Robert Sesek
The CQ bit was checked by rsesek@chromium.org
6 years, 9 months ago (2014-02-27 19:29:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/177243021/20001
6 years, 9 months ago (2014-02-27 19:29:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/177243021/20001
6 years, 9 months ago (2014-02-28 01:01:09 UTC) #15
commit-bot: I haz the power
Change committed as 253994
6 years, 9 months ago (2014-02-28 01:24:34 UTC) #16
Robert Sesek
FYI this has been reopened because it caused crashes on 10.6 layout tests (https://code.google.com/p/chromium/issues/detail?id=306348#c41). I've ...
6 years, 9 months ago (2014-02-28 17:50:26 UTC) #17
Mark Mentovai
LGTM
6 years, 9 months ago (2014-02-28 17:54:57 UTC) #18
Robert Sesek
6 years, 9 months ago (2014-02-28 18:34:05 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 manually as r254175 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698