chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h - Issue 1837233002: Optional <TimeDelta> since they may be non existent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h

Issue 1837233002: Optional <TimeDelta> since they may be non existent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased, Fixed non-deterministic tests and Bryan's review comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc ('K') | « chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc » ('j') | components/page_load_metrics/browser/metrics_web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h

diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h

index dfd69a9e22c278017ba07718777ad4a8da3968b2..9019c7108305208d882017ce5231d3f3efa8ec67 100644

--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h

+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h

@@ -42,6 +42,7 @@ class PageLoadMetricsObserverTestHarness

const PageLoadMetadata& metadata);

const base::HistogramTester& histogram_tester() const;

+ const PageLoadExtraInfo GetPageLoadExtraInfoCommittedLoad();

Charlie Harrison 2016/05/19 18:20:48 Can you explain in a comment what this does? Also

shivanisha 2016/05/23 15:06:43 Since MetricsWebContentsObserver may have many pro

private:

base::HistogramTester histogram_tester_;