chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc - Issue 1837233002: Optional <TimeDelta> since they may be non existent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

Issue 1837233002: Optional <TimeDelta> since they may be non existent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased, Fixed non-deterministic tests and Bryan's review comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h ('K') | « chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h ('k') | components/page_load_metrics/browser/metrics_web_contents_observer.h » ('j') | components/page_load_metrics/browser/metrics_web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

index 26a700d976130c22c7faf9a71d35c734755356d2..f8d0d4e09f9e62290b04af7c0c03e430ccf2dfbf 100644

--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

@@ -116,4 +116,9 @@ PageLoadMetricsObserverTestHarness::histogram_tester() const {

return histogram_tester_;

}

+const PageLoadExtraInfo

+PageLoadMetricsObserverTestHarness::GetPageLoadExtraInfoCommittedLoad() {

+ return observer_->GetPageLoadExtraInfoCommittedLoad();

} // namespace page_load_metrics