chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc - Issue 1837233002: Optional <TimeDelta> since they may be non existent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

Issue 1837233002: Optional <TimeDelta> since they may be non existent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Inter process time ticks skew related error fixed, Rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc » ('j') | components/page_load_metrics/browser/metrics_web_contents_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

index a26c8bad2a62f972d48d0c19460bb9ee02090aec..c83e0b61bb3059dfb647608e53005255d7d3b33c 100644

--- a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

@@ -48,7 +48,7 @@ DocumentWritePageLoadMetricsObserver::DocumentWritePageLoadMetricsObserver() {}

void DocumentWritePageLoadMetricsObserver::OnComplete(

const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& info) {

- if (info.time_to_commit.is_zero() || timing.IsEmpty())

+ if (!info.time_to_commit || timing.IsEmpty())

return;

if (info.metadata.behavior_flags &

blink::WebLoadingBehaviorFlag::WebLoadingBehaviorDocumentWriteEvaluator) {

@@ -78,9 +78,9 @@ void DocumentWritePageLoadMetricsObserver::LogDocumentWriteEvaluatorData(

timing.first_contentful_paint - timing.parse_start);

}

- const bool incomplete_parse_in_foreground =

- timing.parse_stop.is_zero() && info.started_in_foreground &&

- info.first_background_time.is_zero();

+ const bool incomplete_parse_in_foreground = timing.parse_stop.is_zero() &&

+ info.started_in_foreground &&

+ !info.first_background_time;

if (incomplete_parse_in_foreground ||

WasStartedInForegroundEventInForeground(timing.parse_stop, info)) {

PAGE_LOAD_HISTOGRAM(internal::kHistogramDocWriteParseBlockedOnScript,