chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc - Issue 1837233002: Optional <TimeDelta> since they may be non existent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 1837233002: Optional <TimeDelta> since they may be non existent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Inter process time ticks skew related error fixed, Rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc » ('j') | components/page_load_metrics/browser/metrics_web_contents_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

index 922fa5620c11c1e8fff25a1d9d4f14441bb37a7f..113f3199aca7f61b2291a231e65ae743b5e8d94d 100644

--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

@@ -220,7 +220,7 @@ TEST_F(CorePageLoadMetricsObserverTest, BackgroundDifferentHistogram) {

TEST_F(CorePageLoadMetricsObserverTest, OnlyBackgroundLaterEvents) {

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1);

- // Set these events at 1 microsecond so they are definitely occur before we

+ // Set these events at 1 microsecond so they definitely occur before we

// background the tab later in the test.

timing.response_start = base::TimeDelta::FromMicroseconds(1);

timing.dom_loading = base::TimeDelta::FromMicroseconds(1);

@@ -229,7 +229,7 @@ TEST_F(CorePageLoadMetricsObserverTest, OnlyBackgroundLaterEvents) {

NavigateAndCommit(GURL(kDefaultTestUrl));

SimulateTimingUpdate(timing);

- // Background the tab, then forground it.

+ // Background the tab, then foreground it.

web_contents()->WasHidden();

web_contents()->WasShown();

timing.first_layout = base::TimeDelta::FromSeconds(3);