Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: ui/gfx/ozone/overlay_hal_ozone.h

Issue 183723003: Overlay interface for ozone. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/ozone/overlay_hal_ozone.h
diff --git a/ui/gfx/ozone/overlay_hal_ozone.h b/ui/gfx/ozone/overlay_hal_ozone.h
new file mode 100644
index 0000000000000000000000000000000000000000..d6d12dfb174e4b1a7615fdecb1cfac0a2869383c
--- /dev/null
+++ b/ui/gfx/ozone/overlay_hal_ozone.h
@@ -0,0 +1,39 @@
+// Copyright 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_GFX_OZONE_OVERLAY_HAL_OZONE_H_
+#define UI_GFX_OZONE_OVERLAY_HAL_OZONE_H_
+
+#include <vector>
+
+#include "base/basictypes.h"
+#include "ui/gfx/gfx_export.h"
+#include "ui/gfx/ozone/surface_factory_ozone.h"
+#include "ui/gfx/rect.h"
+
+namespace gfx {
+
+class GFX_EXPORT OverlayHALOzone {
rjkroege 2014/02/27 23:18:19 More explanation comment. And I don't like the na
alexst (slow to review) 2014/02/28 18:59:34 Done.
+ public:
+ struct OverlaySurfaceCandidate {
rjkroege 2014/02/27 23:18:19 would we ever want to tag this with the gfx::Accel
alexst (slow to review) 2014/02/28 18:59:34 Sometimes there is no widget yet. The compositor m
+ OverlaySurfaceCandidate();
+ ~OverlaySurfaceCandidate();
+
+ SurfaceFactoryOzone::OverlayTransform transform;
+ SurfaceFactoryOzone::BufferFormat format;
+ gfx::Rect rect;
rjkroege 2014/02/27 23:18:19 This is int coordinates right? Would we ever want
alexst (slow to review) 2014/02/28 18:59:34 This is pixel positions, both HWC and DRM have it
+
+ // To be modified by the HAL implementer.
+ bool overlay_handled;
+ };
+
+ typedef std::vector<OverlaySurfaceCandidate> OverlaySurfaceCandidateList;
+ virtual void CheckOverlaySupport(OverlaySurfaceCandidateList* surfaces) = 0;
rjkroege 2014/02/27 23:18:19 aka: iCanHazOverOverlayz? (More comment please?)
alexst (slow to review) 2014/02/28 18:59:34 Done.
+
+ virtual ~OverlayHALOzone();
+};
+
+} // namespace gfx
+
+#endif // UI_GFX_OZONE_OVERLAY_HAL_OZONE_H_

Powered by Google App Engine
This is Rietveld 408576698