Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Side by Side Diff: ui/gfx/ozone/overlay_hal_ozone.h

Issue 183723003: Overlay interface for ozone. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef UI_GFX_OZONE_OVERLAY_HAL_OZONE_H_
6 #define UI_GFX_OZONE_OVERLAY_HAL_OZONE_H_
7
8 #include <vector>
9
10 #include "base/basictypes.h"
11 #include "ui/gfx/gfx_export.h"
12 #include "ui/gfx/ozone/surface_factory_ozone.h"
13 #include "ui/gfx/rect.h"
14
15 namespace gfx {
16
17 class GFX_EXPORT OverlayHALOzone {
rjkroege 2014/02/27 23:18:19 More explanation comment. And I don't like the na
alexst (slow to review) 2014/02/28 18:59:34 Done.
18 public:
19 struct OverlaySurfaceCandidate {
rjkroege 2014/02/27 23:18:19 would we ever want to tag this with the gfx::Accel
alexst (slow to review) 2014/02/28 18:59:34 Sometimes there is no widget yet. The compositor m
20 OverlaySurfaceCandidate();
21 ~OverlaySurfaceCandidate();
22
23 SurfaceFactoryOzone::OverlayTransform transform;
24 SurfaceFactoryOzone::BufferFormat format;
25 gfx::Rect rect;
rjkroege 2014/02/27 23:18:19 This is int coordinates right? Would we ever want
alexst (slow to review) 2014/02/28 18:59:34 This is pixel positions, both HWC and DRM have it
26
27 // To be modified by the HAL implementer.
28 bool overlay_handled;
29 };
30
31 typedef std::vector<OverlaySurfaceCandidate> OverlaySurfaceCandidateList;
32 virtual void CheckOverlaySupport(OverlaySurfaceCandidateList* surfaces) = 0;
rjkroege 2014/02/27 23:18:19 aka: iCanHazOverOverlayz? (More comment please?)
alexst (slow to review) 2014/02/28 18:59:34 Done.
33
34 virtual ~OverlayHALOzone();
35 };
36
37 } // namespace gfx
38
39 #endif // UI_GFX_OZONE_OVERLAY_HAL_OZONE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698