Support the device font cache

Support the device font cache

Reuse the Skia typeface on sucessive text draw calls.
This reduces the SKP size by 100x for some documents.

Note that this does not use a smart pointer for the
Skia typeface object. The downside of doing so is that
it requires all clients that include fx_font.h to also
have access to Skia.

In this specific case, it is preferable to have a
forward declared class to isolate Skia from the rest of PDFium.

R=dsinclair,tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/f8a5ef3056619c1a8e7d1108ac3720c97ca8e67d

[caryclark, 2016-04-04 14:04:33]

Description was changed from

==========
first cut at supporting device font cache

Reuse the Skia typeface on sucessive text draw calls.

BUG=
==========

to

==========
Support the device font cache

Reuse the Skia typeface on sucessive text draw calls.
This reduces the SKP size by 100x for some documents.

Note that this does not use a smart pointer for the
Skia typeface object. The downside of doing so is that
it requires all clients that include fx_font.h to also
have access to Skia.

In this specific case, it is preferable to have a
forward declared class to isolate Skia from the rest of PDFium.

R=dsinclair,tsepez@chromium.org
==========

[caryclark, 2016-04-04 14:04:33]

caryclark@google.com changed reviewers:
+ dsinclair@chromium.org, tsepez@chromium.org

[dsinclair, 2016-04-04 17:09:15]

https://codereview.chromium.org/1837113004/diff/20001/core/include/fxge/fx_fo...
File core/include/fxge/fx_font.h (right):

https://codereview.chromium.org/1837113004/diff/20001/core/include/fxge/fx_fo...
core/include/fxge/fx_font.h:31: class SkTypeface;
Should do something like:

using CFX_TypeFace = SkTypeface; and then use CFX_TypeFace below?

[Tom Sepez, 2016-04-04 18:20:53]

lgtm

[caryclark, 2016-04-04 19:05:00]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 19:05:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1837113004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1837113004/40001

[caryclark, 2016-04-04 19:05:11]

https://codereview.chromium.org/1837113004/diff/20001/core/include/fxge/fx_fo...
File core/include/fxge/fx_font.h (right):

https://codereview.chromium.org/1837113004/diff/20001/core/include/fxge/fx_fo...
core/include/fxge/fx_font.h:31: class SkTypeface;
On 2016/04/04 17:09:15, dsinclair wrote:
> Should do something like:
> 
> using CFX_TypeFace = SkTypeface; and then use CFX_TypeFace below?

Done.

[dsinclair, 2016-04-04 19:10:03]

lgtm

[commit-bot: I haz the power, 2016-04-04 19:20:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 19:20:22]

Dry run: This issue passed the CQ dry run.

[caryclark, 2016-04-04 19:26:51]

The CQ bit was checked by caryclark@google.com

[caryclark, 2016-04-04 19:26:51]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1837113004/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-04-04 19:27:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1837113004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1837113004/40001

[commit-bot: I haz the power, 2016-04-04 19:27:19]

Description was changed from

==========
Support the device font cache

Reuse the Skia typeface on sucessive text draw calls.
This reduces the SKP size by 100x for some documents.

Note that this does not use a smart pointer for the
Skia typeface object. The downside of doing so is that
it requires all clients that include fx_font.h to also
have access to Skia.

In this specific case, it is preferable to have a
forward declared class to isolate Skia from the rest of PDFium.

R=dsinclair,tsepez@chromium.org
==========

to

==========
Support the device font cache

Reuse the Skia typeface on sucessive text draw calls.
This reduces the SKP size by 100x for some documents.

Note that this does not use a smart pointer for the
Skia typeface object. The downside of doing so is that
it requires all clients that include fx_font.h to also
have access to Skia.

In this specific case, it is preferable to have a
forward declared class to isolate Skia from the rest of PDFium.

R=dsinclair,tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/f8a5ef3056619c1a8e7d1108ac3720c97ca8...
==========

[commit-bot: I haz the power, 2016-04-04 19:27:21]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/f8a5ef3056619c1a8e7d1108ac3720c97ca8...