core/fxge/skia/fx_skia_device.cpp - Issue 1837113004: Support the device font cache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxge/skia/fx_skia_device.cpp

Issue 1837113004: Support the device font cache (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxge/skia/fx_skia_device.cpp

diff --git a/core/fxge/skia/fx_skia_device.cpp b/core/fxge/skia/fx_skia_device.cpp

index 745c9b50fd7f05a292800e9038ad2ca12f96fb6c..e61dda68d4ee1a8ea06e0743e50da0e73d60adb4 100644

--- a/core/fxge/skia/fx_skia_device.cpp

+++ b/core/fxge/skia/fx_skia_device.cpp

@@ -320,8 +320,7 @@ FX_BOOL CFX_SkiaDeviceDriver::DrawDeviceText(int nChars,

uint32_t color,

int alpha_flag,

void* pIccTransform) {

- SkAutoTUnref<SkTypeface> typeface(SkTypeface::CreateFromStream(

- new SkMemoryStream(pFont->GetFontData(), pFont->GetSize())));

+ CFX_TypeFace* typeface = pCache->GetDeviceCache(pFont);

SkPaint paint;

paint.setAntiAlias(true);

paint.setColor(color);

« no previous file with comments | « core/fxge/ge/fx_ge_text.cpp ('k') | core/include/fxge/fx_font.h » ('j') | no next file with comments »