Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1837043003: Add a title for the account chooser for one credential displayed. (Closed)

Created:
4 years, 8 months ago by vasilii
Modified:
4 years, 8 months ago
Reviewers:
melandory
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a title for the account chooser for one credential displayed. BUG=598646 Committed: https://crrev.com/a0035c92f76f90d6caa64175d5e7a0957d585d06 Cr-Commit-Position: refs/heads/master@{#383951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -11 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/password_manager/account_chooser_dialog_android.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_view_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_view_utils.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc View 2 chunks +18 lines, -6 lines 0 comments Download
M chrome/browser/ui/passwords/password_dialog_controller_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vasilii
Hi Tanya, please review.
4 years, 8 months ago (2016-03-29 14:31:18 UTC) #2
melandory
On 2016/03/29 14:31:18, vasilii wrote: > Hi Tanya, > > please review. lgtm
4 years, 8 months ago (2016-03-30 11:36:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837043003/1
4 years, 8 months ago (2016-03-30 11:49:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 12:17:29 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 12:19:32 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a0035c92f76f90d6caa64175d5e7a0957d585d06
Cr-Commit-Position: refs/heads/master@{#383951}

Powered by Google App Engine
This is Rietveld 408576698