chrome/browser/ui/passwords/manage_passwords_view_utils.cc - Issue 1837043003: Add a title for the account chooser for one credential displayed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_view_utils.cc

Issue 1837043003: Add a title for the account chooser for one credential displayed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_view_utils.h ('k') | chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_view_utils.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_view_utils.cc b/chrome/browser/ui/passwords/manage_passwords_view_utils.cc

index f584e39da7e42ea6d89ecd2833393df324f667d4..093382d1470c8abab686c6f852073e84c9633500 100644

--- a/chrome/browser/ui/passwords/manage_passwords_view_utils.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_view_utils.cc

@@ -143,11 +143,14 @@ void GetManagePasswordsDialogTitleText(const GURL& user_visible_url,

void GetAccountChooserDialogTitleTextAndLinkRange(

bool is_smartlock_branding_enabled,

+ bool many_accounts,

base::string16* title,

gfx::Range* title_link_range) {

+ int string_id = many_accounts

+ ? IDS_PASSWORD_MANAGER_ACCOUNT_CHOOSER_TITLE_MANY_ACCOUNTS

+ : IDS_PASSWORD_MANAGER_ACCOUNT_CHOOSER_TITLE_ONE_ACCOUNT;

GetBrandedTextAndLinkRange(is_smartlock_branding_enabled,

- IDS_PASSWORD_MANAGER_ACCOUNT_CHOOSER_TITLE,

+ string_id, string_id,

title, title_link_range);

}