Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183693015: <webview>: Move Dialog API to stable. (Closed)

Created:
6 years, 9 months ago by Fady Samuel
Modified:
6 years, 9 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

<webview>: Move Dialog API to stable. BUG=313868 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255551

Patch Set 1 #

Patch Set 2 : Removed C++ check #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -106 lines) Patch
M chrome/browser/apps/web_view_browsertest.cc View 2 chunks +2 lines, -14 lines 1 comment Download
M chrome/browser/guestview/webview/webview_guest.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/web_view.js View 2 chunks +86 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/web_view_experimental.js View 2 chunks +0 lines, -86 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Fady Samuel
6 years, 9 months ago (2014-03-06 17:38:11 UTC) #1
lazyboy
One q. https://codereview.chromium.org/183693015/diff/20001/chrome/browser/apps/web_view_browsertest.cc File chrome/browser/apps/web_view_browsertest.cc (left): https://codereview.chromium.org/183693015/diff/20001/chrome/browser/apps/web_view_browsertest.cc#oldcode1794 chrome/browser/apps/web_view_browsertest.cc:1794: // Fails on official Windows and Linux ...
6 years, 9 months ago (2014-03-06 17:47:32 UTC) #2
Fady Samuel
On 2014/03/06 17:47:32, lazyboy wrote: > One q. > > https://codereview.chromium.org/183693015/diff/20001/chrome/browser/apps/web_view_browsertest.cc > File chrome/browser/apps/web_view_browsertest.cc (left): ...
6 years, 9 months ago (2014-03-06 17:50:36 UTC) #3
lazyboy
lgtm OK.
6 years, 9 months ago (2014-03-06 17:53:05 UTC) #4
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 9 months ago (2014-03-06 17:53:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/183693015/20001
6 years, 9 months ago (2014-03-06 17:54:55 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 17:58:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-06 17:58:49 UTC) #8
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 9 months ago (2014-03-06 22:31:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/183693015/20001
6 years, 9 months ago (2014-03-06 22:49:52 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 05:35:34 UTC) #11
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests, telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=233626
6 years, 9 months ago (2014-03-07 05:35:35 UTC) #12
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 9 months ago (2014-03-07 05:41:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/183693015/20001
6 years, 9 months ago (2014-03-07 05:43:59 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 08:46:34 UTC) #15
Message was sent while issue was closed. 
Change committed as 255551

Powered by Google App Engine
This is Rietveld 408576698