Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1897)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/guestview/webview/webview_guest.cc

Issue 183693015: <webview>: Move Dialog API to stable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed C++ check Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/apps/web_view_browsertest.cc ('K') | « chrome/browser/apps/web_view_browsertest.cc ('k') | chrome/renderer/resources/extensions/web_view.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/guestview/webview/webview_guest.cc
diff --git a/chrome/browser/guestview/webview/webview_guest.cc b/chrome/browser/guestview/webview/webview_guest.cc
index 6baba57ec469610403e504b69ef336e2d610c750..029fe542483258f17afefa56fde3b3db934ce660 100644
--- a/chrome/browser/guestview/webview/webview_guest.cc
+++ b/chrome/browser/guestview/webview/webview_guest.cc
@@ -450,12 +450,6 @@ bool WebViewGuest::RequestPermission(
break;
}
case BROWSER_PLUGIN_PERMISSION_TYPE_JAVASCRIPT_DIALOG: {
- chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();
- if (channel > chrome::VersionInfo::CHANNEL_DEV) {
- // 'dialog' API is not available in stable/beta.
- callback.Run(false, std::string());
- return true;
- }
DispatchEvent(new GuestView::Event(webview::kEventDialog,
args.Pass()));
break;
« chrome/browser/apps/web_view_browsertest.cc ('K') | « chrome/browser/apps/web_view_browsertest.cc ('k') | chrome/renderer/resources/extensions/web_view.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698