Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183693004: Move showContextMenu from WebViewClient to WebFrameClient. (Closed)

Created:
6 years, 9 months ago by jam
Modified:
6 years, 9 months ago
Reviewers:
dglazkov
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move showContextMenu from WebViewClient to WebFrameClient. BUG=304341 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168165

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : update with workaround for clang warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M Source/web/ContextMenuClientImpl.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M public/web/WebFrameClient.h View 1 2 3 chunks +11 lines, -0 lines 0 comments Download
M public/web/WebViewClient.h View 1 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
jam
6 years, 9 months ago (2014-02-27 23:36:12 UTC) #1
dglazkov
lgtm
6 years, 9 months ago (2014-02-27 23:36:42 UTC) #2
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-02-27 23:44:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/183693004/40001
6 years, 9 months ago (2014-02-27 23:44:44 UTC) #4
commit-bot: I haz the power
Failed to get patchset properties (patchset not found?)
6 years, 9 months ago (2014-02-28 00:10:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/183693004/20001
6 years, 9 months ago (2014-02-28 00:10:19 UTC) #6
commit-bot: I haz the power
Failed to trigger a try job on win_layout HTTP Error 400: Bad Request
6 years, 9 months ago (2014-02-28 00:15:49 UTC) #7
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-02-28 16:41:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/183693004/60001
6 years, 9 months ago (2014-02-28 16:41:29 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 17:27:52 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) blink_heap_unittests, blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, ...
6 years, 9 months ago (2014-02-28 17:27:53 UTC) #11
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-02-28 19:29:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/183693004/60001
6 years, 9 months ago (2014-02-28 19:29:52 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 20:46:18 UTC) #14
Message was sent while issue was closed. 
Change committed as 168165

Powered by Google App Engine
This is Rietveld 408576698