Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Side by Side Diff: public/web/WebViewClient.h

Issue 183693004: Move showContextMenu from WebViewClient to WebFrameClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: update with workaround for clang warning Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « public/web/WebFrameClient.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 class WebSpeechInputListener; 74 class WebSpeechInputListener;
75 class WebSpeechRecognizer; 75 class WebSpeechRecognizer;
76 class WebStorageNamespace; 76 class WebStorageNamespace;
77 class WebURL; 77 class WebURL;
78 class WebURLRequest; 78 class WebURLRequest;
79 class WebUserMediaClient; 79 class WebUserMediaClient;
80 class WebView; 80 class WebView;
81 class WebWidget; 81 class WebWidget;
82 struct WebColorSuggestion; 82 struct WebColorSuggestion;
83 struct WebConsoleMessage; 83 struct WebConsoleMessage;
84 struct WebContextMenuData;
85 struct WebDateTimeChooserParams; 84 struct WebDateTimeChooserParams;
86 struct WebPoint; 85 struct WebPoint;
87 struct WebPopupMenuInfo; 86 struct WebPopupMenuInfo;
88 struct WebRect; 87 struct WebRect;
89 struct WebSize; 88 struct WebSize;
90 struct WebWindowFeatures; 89 struct WebWindowFeatures;
91 90
92 // Since a WebView is a WebWidget, a WebViewClient is a WebWidgetClient. 91 // Since a WebView is a WebWidget, a WebViewClient is a WebWidgetClient.
93 // Virtual inheritance allows an implementation of WebWidgetClient to be 92 // Virtual inheritance allows an implementation of WebWidgetClient to be
94 // easily reused as part of an implementation of WebViewClient. 93 // easily reused as part of an implementation of WebViewClient.
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 249
251 // Called when script modifies window.status 250 // Called when script modifies window.status
252 virtual void setStatusText(const WebString&) { } 251 virtual void setStatusText(const WebString&) { }
253 252
254 // Called when hovering over an anchor with the given URL. 253 // Called when hovering over an anchor with the given URL.
255 virtual void setMouseOverURL(const WebURL&) { } 254 virtual void setMouseOverURL(const WebURL&) { }
256 255
257 // Called when keyboard focus switches to an anchor with the given URL. 256 // Called when keyboard focus switches to an anchor with the given URL.
258 virtual void setKeyboardFocusURL(const WebURL&) { } 257 virtual void setKeyboardFocusURL(const WebURL&) { }
259 258
260 // Shows a context menu with commands relevant to a specific element on
261 // the given frame. Additional context data is supplied.
262 virtual void showContextMenu(WebFrame*, const WebContextMenuData&) { }
263
264 // Called when the data attached to the currently displayed context menu is 259 // Called when the data attached to the currently displayed context menu is
265 // invalidated. The context menu may be closed if possible. 260 // invalidated. The context menu may be closed if possible.
266 virtual void clearContextMenu() { } 261 virtual void clearContextMenu() { }
267 262
268 // Called when a drag-n-drop operation should begin. 263 // Called when a drag-n-drop operation should begin.
269 virtual void startDragging(WebFrame*, const WebDragData&, WebDragOperationsM ask, const WebImage&, const WebPoint& dragImageOffset) { } 264 virtual void startDragging(WebFrame*, const WebDragData&, WebDragOperationsM ask, const WebImage&, const WebPoint& dragImageOffset) { }
270 265
271 // Called to determine if drag-n-drop operations may initiate a page 266 // Called to determine if drag-n-drop operations may initiate a page
272 // navigation. 267 // navigation.
273 virtual bool acceptsLoadDrops() { return true; } 268 virtual bool acceptsLoadDrops() { return true; }
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 // Informs the browser that the draggable regions have been updated. 413 // Informs the browser that the draggable regions have been updated.
419 virtual void draggableRegionsChanged() { } 414 virtual void draggableRegionsChanged() { }
420 415
421 protected: 416 protected:
422 ~WebViewClient() { } 417 ~WebViewClient() { }
423 }; 418 };
424 419
425 } // namespace blink 420 } // namespace blink
426 421
427 #endif 422 #endif
OLDNEW
« no previous file with comments | « public/web/WebFrameClient.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698