Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1836853002: Avoid illegal definition of snprintf in VS 2015 (Closed)

Created:
4 years, 8 months ago by dominicc (has gone to gerrit)
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Avoid illegal definition of snprintf in VS 2015 VS 2015 supplies an implementation of snprintf which makes definining it to _snprintf illegal - previously it was just a really bad idea. This reinstates the compiler version check so that libxml will compile in Chromium. README.chromium was also updated to make it explicit that these checks need to be added (for now) when config.h is copied. A corresponding change will need to be made upstream. BUG=440500, 591920 Review URL: https://codereview.chromium.org/1770093002 Cr-Commit-Position: refs/heads/master@{#379755} (cherry picked from commit f7bd300e8c52d6ebb7575a28d4cd9d3bdccaf439) Committed: https://chromium.googlesource.com/chromium/src/+/40ff9d7fda350ccb83c171c68b60290d6ff3b74d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/libxml/README.chromium View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/libxml/win32/config.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dominicc (has gone to gerrit)
4 years, 8 months ago (2016-03-28 12:48:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
40ff9d7fda350ccb83c171c68b60290d6ff3b74d.

Powered by Google App Engine
This is Rietveld 408576698