Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: third_party/libxml/README.chromium

Issue 1836853002: Avoid illegal definition of snprintf in VS 2015 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/libxml/win32/config.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libxml/README.chromium
diff --git a/third_party/libxml/README.chromium b/third_party/libxml/README.chromium
index c3536ee2348dda6f8af44c5dc2c71cbff4182e17..33d9f98f638f40572dfed3ae1785a47ebe90c642 100644
--- a/third_party/libxml/README.chromium
+++ b/third_party/libxml/README.chromium
@@ -36,6 +36,9 @@ On a Windows box:
cd libxml2-2.9.2\win32
cscript //E:jscript configure.js compiler=msvc iconv=no icu=yes ftp=no http=no
Then copy VC10/config.h and include/libxml/xmlversion.h to win32/ on Linux.
+Patch win32/config.h to wrap the #define snprintf with:
+ #if _MSC_VER < 1900
+ #endif
Remove:
src/doc/
« no previous file with comments | « no previous file | third_party/libxml/win32/config.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698