Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183663027: Changing the email reference. (Closed)

Created:
6 years, 9 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 9 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Changing the email reference. BUG=341662 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255532

Patch Set 1 #

Patch Set 2 : Fixed unit test breakage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chromeos/ui/idle_app_name_notification_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ui/idle_app_name_notification_view_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (0 generated)
Mr4D (OOO till 08-26)
Xiyuan, this should be the correct manifest path & key. Please have a look!
6 years, 9 months ago (2014-03-06 01:24:07 UTC) #1
xiyuan
lgtm
6 years, 9 months ago (2014-03-06 01:30:19 UTC) #2
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 9 months ago (2014-03-06 04:03:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/183663027/1
6 years, 9 months ago (2014-03-06 04:05:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 05:37:53 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=207983
6 years, 9 months ago (2014-03-06 05:37:53 UTC) #6
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 9 months ago (2014-03-06 15:32:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/183663027/1
6 years, 9 months ago (2014-03-06 15:32:55 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 16:51:02 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=208065
6 years, 9 months ago (2014-03-06 16:51:03 UTC) #10
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 9 months ago (2014-03-06 17:26:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/183663027/20001
6 years, 9 months ago (2014-03-06 17:27:12 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 17:30:42 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-06 17:30:42 UTC) #14
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 9 months ago (2014-03-06 18:04:51 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/183663027/20001
6 years, 9 months ago (2014-03-06 18:06:04 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 20:03:28 UTC) #17
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=233291
6 years, 9 months ago (2014-03-06 20:03:29 UTC) #18
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 9 months ago (2014-03-06 20:16:47 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/183663027/20001
6 years, 9 months ago (2014-03-06 20:54:16 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/183663027/20001
6 years, 9 months ago (2014-03-06 21:41:35 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/183663027/20001
6 years, 9 months ago (2014-03-06 22:17:26 UTC) #22
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 04:55:42 UTC) #23
Message was sent while issue was closed. 
Change committed as 255532

Powered by Google App Engine
This is Rietveld 408576698