chrome/browser/chromeos/ui/idle_app_name_notification_view.cc - Issue 183663027: Changing the email reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/ui/idle_app_name_notification_view.cc

Issue 183663027: Changing the email reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed unit test breakage Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/ui/idle_app_name_notification_view.cc

diff --git a/chrome/browser/chromeos/ui/idle_app_name_notification_view.cc b/chrome/browser/chromeos/ui/idle_app_name_notification_view.cc

index 4052d5ec3fb8384db5f504856baa1fc77a4ccf1d..c827bceda25194e3c60ae68ad4024a1e11b9b8d7 100644

--- a/chrome/browser/chromeos/ui/idle_app_name_notification_view.cc

+++ b/chrome/browser/chromeos/ui/idle_app_name_notification_view.cc

@@ -287,7 +287,7 @@ void IdleAppNameNotificationView::ShowMessage(

app_name = base::UTF8ToUTF16(extension->name());

// TODO(skuhne): This might not be enough since the author flag is not

// explicitly enforced by us, but for Kiosk mode we could maybe require it.

- extension->manifest()->GetString("author", &author);

+ extension->manifest()->GetString("author.email", &author);

if (ContainsOnlyWhitespace(author)) {

error = true;

author = l10n_util::GetStringUTF16(

« no previous file with comments | « no previous file | chrome/browser/chromeos/ui/idle_app_name_notification_view_unittest.cc » ('j') | no next file with comments »