MD Settings: Use paper-dropdown-menu for search engines.

MD Settings: Use paper-dropdown-menu for search engines.

BUG=597874
Committed: https://crrev.com/387ffbcef8667b2c04ef00e48de49a777ece556d
Cr-Commit-Position: refs/heads/master@{#384117}

[dpapad, 2016-03-28 21:39:45]

Description was changed from

==========
MD Settings: Use paper-dropdown-menu for search engines, WIP.

BUG=
==========

to

==========
MD Settings: Use paper-dropdown-menu for search engines, WIP.

BUG=597874
==========

[dpapad, 2016-03-28 21:40:01]

Description was changed from

==========
MD Settings: Use paper-dropdown-menu for search engines, WIP.

BUG=597874
==========

to

==========
MD Settings: Use paper-dropdown-menu for search engines.

BUG=597874
==========

[dpapad, 2016-03-28 22:03:42]

Patchset #2 (id:20001) has been deleted

[dpapad, 2016-03-28 22:03:48]

Patchset #1 (id:1) has been deleted

[dpapad, 2016-03-29 21:16:44]

Patchset #1 (id:40001) has been deleted

[dpapad, 2016-03-29 21:20:14]

dpapad@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dschuyler, 2016-03-30 02:42:19]

LGTM with a question/suggestion.

https://codereview.chromium.org/1836583003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/search_page/search_page.html (right):

https://codereview.chromium.org/1836583003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/search_page/search_page.html:30:
<paper-item>[[item.name]]</paper-item>
Will these paper-items work as <div>s?

[dpapad, 2016-03-30 17:36:54]

https://codereview.chromium.org/1836583003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/search_page/search_page.html (right):

https://codereview.chromium.org/1836583003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/search_page/search_page.html:30:
<paper-item>[[item.name]]</paper-item>
On 2016/03/30 at 02:42:19, dschuyler wrote:
> Will these paper-items work as <div>s?

Done, but it requires basically copying over all styles from paper-item to the
divs. See latest patch. Let me know if you think this is worth it, or I should
revert to previous patch.

Eventually it would be nice to unify our dropdown menus which currently are not
consistent, to use one of the following.
1) paper-menu + paper-item
2) paper-listbox + div
3) paper-listbox + paper-item

No1 which is what currently we have been using in most places is not ideal
(paper-menu was designed for submenus and I think it has been deprecated).

[dschuyler, 2016-03-30 20:42:55]

https://codereview.chromium.org/1836583003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/search_page/search_page.html (right):

https://codereview.chromium.org/1836583003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/search_page/search_page.html:30:
<paper-item>[[item.name]]</paper-item>
On 2016/03/30 17:36:54, dpapad wrote:
> On 2016/03/30 at 02:42:19, dschuyler wrote:
> > Will these paper-items work as <div>s?
> 
> Done, but it requires basically copying over all styles from paper-item to the
> divs. See latest patch. Let me know if you think this is worth it, or I should
> revert to previous patch.
>
> Eventually it would be nice to unify our dropdown menus which currently are
not
> consistent, to use one of the following.
> 1) paper-menu + paper-item
> 2) paper-listbox + div
> 3) paper-listbox + paper-item

That sounds good to me.  I think option 2 will serve us best.
Let's check with Dan and Michael.

I also think that putting the styling in a style-module would
be nice (so that it doesn't need to be replicated).  That, IMO,
could be done when the second dropdown is converted (i.e. it 
doesn't need to be this CL since this is the one copy of it now).


> 
> No1 which is what currently we have been using in most places is not ideal
> (paper-menu was designed for submenus and I think it has been deprecated).

[dpapad, 2016-03-30 21:05:55]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-03-30 21:05:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/1836583003/#ps100001
(title: "Change paper-item to div")

[commit-bot: I haz the power, 2016-03-30 21:06:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1836583003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1836583003/100001

[commit-bot: I haz the power, 2016-03-30 22:27:53]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-03-30 22:28:57]

Description was changed from

==========
MD Settings: Use paper-dropdown-menu for search engines.

BUG=597874
==========

to

==========
MD Settings: Use paper-dropdown-menu for search engines.

BUG=597874

Committed: https://crrev.com/387ffbcef8667b2c04ef00e48de49a777ece556d
Cr-Commit-Position: refs/heads/master@{#384117}
==========

[commit-bot: I haz the power, 2016-03-30 22:28:58]

Patchset 3 (id:??) landed as
https://crrev.com/387ffbcef8667b2c04ef00e48de49a777ece556d
Cr-Commit-Position: refs/heads/master@{#384117}