Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: chrome/browser/resources/settings/search_page/search_page.html

Issue 1836583003: MD Settings: Use paper-dropdown-menu for search engines. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/pap er-dropdown-menu.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-lis tbox.html">
4 <link rel="import" href="chrome://md-settings/search_engines_page/search_engines _page.html"> 7 <link rel="import" href="chrome://md-settings/search_engines_page/search_engines _page.html">
5 <link rel="import" href="chrome://md-settings/search_engines_page/search_engines _browser_proxy.html"> 8 <link rel="import" href="chrome://md-settings/search_engines_page/search_engines _browser_proxy.html">
6 <link rel="import" href="chrome://md-settings/settings_page/settings_animated_pa ges.html"> 9 <link rel="import" href="chrome://md-settings/settings_page/settings_animated_pa ges.html">
7 <link rel="import" href="chrome://md-settings/settings_page/settings_subheader.h tml"> 10 <link rel="import" href="chrome://md-settings/settings_page/settings_subheader.h tml">
8 <link rel="import" href="chrome://md-settings/settings_shared_css.html"> 11 <link rel="import" href="chrome://md-settings/settings_shared_css.html">
9 12
10 <dom-module id="settings-search-page"> 13 <dom-module id="settings-search-page">
11 <link rel="import" type="css" href="search_page.css">
12 <template> 14 <template>
13 <style include="settings-shared"></style> 15 <style include="settings-shared">
16 paper-item:hover {
17 background-color: var(--settings-hover-color);
18 }
19 </style>
14 <settings-animated-pages id="pages" current-route="{{currentRoute}}" 20 <settings-animated-pages id="pages" current-route="{{currentRoute}}"
15 section="search"> 21 section="search">
16 <neon-animatable id="main"> 22 <neon-animatable id="main">
17 <div class="settings-box first"> 23 <div class="settings-box first">
18 <p class="start" i18n-content="searchExplanation"></p> 24 <p class="start" i18n-content="searchExplanation"></p>
19 <select id="searchEnginesMenu" on-change="onDefaultEngineChanged_"> 25 <paper-dropdown-menu>
20 <template is="dom-repeat" items="[[searchEngines_]]"> 26 <paper-listbox class="dropdown-content"
21 <option selected$="[[item.default]]" value="[[item.modelIndex]]"> 27 selected="[[getSelectedSearchEngineIndex_(searchEngines_)]]"
22 [[item.name]] 28 on-iron-select="onIronSelect_">
23 </option> 29 <template is="dom-repeat" items="[[searchEngines_]]">
24 </template> 30 <paper-item>[[item.name]]</paper-item>
dschuyler 2016/03/30 02:42:19 Will these paper-items work as <div>s?
dpapad 2016/03/30 17:36:54 Done, but it requires basically copying over all s
dschuyler 2016/03/30 20:42:54 That sounds good to me. I think option 2 will ser
25 </select> 31 </template>
32 </paper-listbox>
33 </paper-dropdown-menu>
26 </div> 34 </div>
27 <div class="settings-box"> 35 <div class="settings-box">
28 <paper-button i18n-content="searchEnginesManage" 36 <paper-button i18n-content="searchEnginesManage"
29 on-tap="onManageSearchEnginesTap_" class="primary-button"> 37 on-tap="onManageSearchEnginesTap_" class="primary-button">
30 </paper-button> 38 </paper-button>
31 </div> 39 </div>
32 </neon-animatable> 40 </neon-animatable>
33 <neon-animatable id="search-engines"> 41 <neon-animatable id="search-engines">
34 <settings-subheader i18n-values="page-title:searchEnginesManage"> 42 <settings-subheader i18n-values="page-title:searchEnginesManage">
35 </settings-subheader> 43 </settings-subheader>
36 <settings-search-engines-page></settings-search-engines-page> 44 <settings-search-engines-page></settings-search-engines-page>
37 </neon-animatable> 45 </neon-animatable>
38 </settings-animated-pages> 46 </settings-animated-pages>
39 </template> 47 </template>
40 <script src="search_page.js"></script> 48 <script src="search_page.js"></script>
41 </dom-module> 49 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698