Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1836353007: Fix isolate_tests after https://codereview.chromium.org/1825723002 (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
robliao
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix isolate_tests after https://codereview.chromium.org/1825723002 That change added display_unittests on swarming to several testing/buildbot json files, but didn't update gn_migration.gypi to make sure display_unittests_run runs on all platforms (so when the test was prepared for swarming, the corresponding .isolated file might not yet have been created). Should fix e.g. the red isolate_tests step on https://build.chromium.org/p/chromium.fyi/builders/ClangToTMacASan/builds/5203 BUG=597105 TBR=robliao Committed: https://crrev.com/9f9318e2cf3a367967014a354e0d280bdf66247c Cr-Commit-Position: refs/heads/master@{#383963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/gn_migration.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Nico
(took me a bit longer to find than necessary because https://codereview.chromium.org/1825723002's CL description doesn't say ...
4 years, 8 months ago (2016-03-30 11:59:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836353007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836353007/1
4 years, 8 months ago (2016-03-30 11:59:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 13:18:40 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9f9318e2cf3a367967014a354e0d280bdf66247c Cr-Commit-Position: refs/heads/master@{#383963}
4 years, 8 months ago (2016-03-30 13:19:46 UTC) #9
robliao
4 years, 8 months ago (2016-03-30 17:11:00 UTC) #10
Message was sent while issue was closed.
On 2016/03/30 13:19:46, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/9f9318e2cf3a367967014a354e0d280bdf66247c
> Cr-Commit-Position: refs/heads/master@{#383963}

I'll have to separate the changes for next time. Adding them made sense at the
time to get trybot coverage.
I guess the CQ dry-run gave a false sense of confidence succeeding. I wonder if
there's a sanity check way to verify the configs before committing.

Powered by Google App Engine
This is Rietveld 408576698