third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility.html - Issue 1836203002: Change the battery-status layout tests to use JS mocks.

Unified Diff: third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility.html

Issue 1836203002: Change the battery-status layout tests to use JS mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/battery-status/multiple-promises.html ('K') | « third_party/WebKit/LayoutTests/battery-status/multiple-windows.html ('k') | third_party/WebKit/LayoutTests/battery-status/no-gc-with-eventlisteners.html » ('j') | third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility.html

diff --git a/third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility.html b/third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility.html

index 230f148b4d8c8d6ca48c662b0df24f45d403c1f7..1005ccf4fefea6e02f37b0615150de887c8f501e 100644

--- a/third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility.html

+++ b/third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility.html

@@ -2,6 +2,8 @@

<html>

<body>

+<script src="../resources/mojo-helpers.js"></script>

+<script src="resources/mock-battery-monitor.js"></script>

description("Test multiple windows with page visibility.");

@@ -17,31 +19,6 @@ testRunner.waitUntilDone();

testRunner.setCanOpenWindows();

testRunner.setCloseRemainingWindowsWhenComplete(true);

-var mockBatteryInfo;

-function setAndFireMockBatteryInfo(charging, chargingTime, dischargingTime, level) {

- mockBatteryInfo = { charging: charging,

- chargingTime: chargingTime,

- dischargingTime: dischargingTime,

- level: level };

- window.internals.updateBatteryStatus(charging, chargingTime, dischargingTime, level);

-// compare obtained battery values with the mock values

-function checkBatteryInfo(batteryManager) {

- batteryInfo = batteryManager;

- shouldBeDefined("batteryInfo");

- shouldBeDefined("mockBatteryInfo");

- shouldBe('batteryInfo.charging', 'mockBatteryInfo.charging');

- shouldBe('batteryInfo.chargingTime', 'mockBatteryInfo.chargingTime');

- shouldBe('batteryInfo.dischargingTime', 'mockBatteryInfo.dischargingTime');

- shouldBe('batteryInfo.level', 'mockBatteryInfo.level');

-function batteryStatusFailure() {

- testFailed('failed to successfully resolve the promise');

- setTimeout(finishJSTest, 0);

var battery;

function batteryStatusSuccess(batteryManager) {

battery = batteryManager;

@@ -86,8 +63,10 @@ function failAndFinish() {

}

debug("first window: page is visible");

-navigator.getBattery().then(batteryStatusSuccess, batteryStatusFailure);

-setAndFireMockBatteryInfo(false, 10, 20, 0.5);

+ready.then(() => {

+ navigator.getBattery().then(batteryStatusSuccess, batteryStatusFailure);

+ setAndFireMockBatteryInfo(false, 10, 20, 0.5);

+});

</script>

</body>

</html>